* [PATCH v4 1/3] arm: dts: nuvoton: npcm7xx: Drop bogus FIU memory reg-names
2026-06-09 16:39 [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Tomer Maimon
@ 2026-06-09 16:39 ` Tomer Maimon
2026-06-09 16:39 ` [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names Tomer Maimon
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Tomer Maimon @ 2026-06-09 16:39 UTC (permalink / raw)
To: andrew, broonie, robh, krzk+dt, conor+dt
Cc: openbmc, linux-spi, devicetree, linux-kernel, avifishman70,
tmaimon77, tali.perry1, venture, yuenn, benjaminfair,
Krzysztof Kozlowski
The NPCM7xx FIU controller nodes only describe the control register block,
but they still advertise a second "memory" entry in reg-names. Drop the
bogus name so the DTS matches the resources actually present in each node.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
index ab3c3c5713ae..a16450abea0e 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
@@ -191,7 +191,7 @@ fiu0: spi@fb000000 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0xfb000000 0x1000>;
- reg-names = "control", "memory";
+ reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPI0>;
clock-names = "clk_spi0";
status = "disabled";
@@ -202,7 +202,7 @@ fiu3: spi@c0000000 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0xc0000000 0x1000>;
- reg-names = "control", "memory";
+ reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPI3>;
clock-names = "clk_spi3";
pinctrl-names = "default";
@@ -215,7 +215,7 @@ fiux: spi@fb001000 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0xfb001000 0x1000>;
- reg-names = "control", "memory";
+ reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPIX>;
clock-names = "clk_spix";
status = "disabled";
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-09 16:39 [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Tomer Maimon
2026-06-09 16:39 ` [PATCH v4 1/3] arm: dts: nuvoton: npcm7xx: Drop bogus FIU memory reg-names Tomer Maimon
@ 2026-06-09 16:39 ` Tomer Maimon
2026-06-10 7:19 ` Krzysztof Kozlowski
2026-06-10 10:49 ` Andrew Jeffery
2026-06-09 16:39 ` [PATCH v4 3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema Tomer Maimon
2026-06-11 18:56 ` (subset) [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Mark Brown
3 siblings, 2 replies; 11+ messages in thread
From: Tomer Maimon @ 2026-06-09 16:39 UTC (permalink / raw)
To: andrew, broonie, robh, krzk+dt, conor+dt
Cc: openbmc, linux-spi, devicetree, linux-kernel, avifishman70,
tmaimon77, tali.perry1, venture, yuenn, benjaminfair
The NPCM7xx FIU controller driver gets its single clock with
devm_clk_get_enabled(dev, NULL) and does not perform a named
clock lookup. Drop the redundant clock-names properties from the
FIU controller nodes so the DTS describes only the resources the
driver actually uses.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
index a16450abea0e..83cd10b47273 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
@@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
reg = <0xfb000000 0x1000>;
reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPI0>;
- clock-names = "clk_spi0";
status = "disabled";
};
@@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
reg = <0xc0000000 0x1000>;
reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPI3>;
- clock-names = "clk_spi3";
pinctrl-names = "default";
pinctrl-0 = <&spi3_pins>;
status = "disabled";
@@ -217,7 +215,6 @@ fiux: spi@fb001000 {
reg = <0xfb001000 0x1000>;
reg-names = "control";
clocks = <&clk NPCM7XX_CLK_SPIX>;
- clock-names = "clk_spix";
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-09 16:39 ` [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names Tomer Maimon
@ 2026-06-10 7:19 ` Krzysztof Kozlowski
2026-06-10 10:49 ` Andrew Jeffery
1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-10 7:19 UTC (permalink / raw)
To: Tomer Maimon
Cc: andrew, broonie, robh, krzk+dt, conor+dt, openbmc, linux-spi,
devicetree, linux-kernel, avifishman70, tali.perry1, venture,
yuenn, benjaminfair
On Tue, Jun 09, 2026 at 07:39:18PM +0300, Tomer Maimon wrote:
> The NPCM7xx FIU controller driver gets its single clock with
> devm_clk_get_enabled(dev, NULL) and does not perform a named
> clock lookup. Drop the redundant clock-names properties from the
> FIU controller nodes so the DTS describes only the resources the
> driver actually uses.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-09 16:39 ` [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names Tomer Maimon
2026-06-10 7:19 ` Krzysztof Kozlowski
@ 2026-06-10 10:49 ` Andrew Jeffery
2026-06-10 11:56 ` Tomer Maimon
1 sibling, 1 reply; 11+ messages in thread
From: Andrew Jeffery @ 2026-06-10 10:49 UTC (permalink / raw)
To: Tomer Maimon, broonie, robh, krzk+dt, conor+dt
Cc: openbmc, linux-spi, devicetree, linux-kernel, avifishman70,
tali.perry1, venture, yuenn, benjaminfair
On Tue, 2026-06-09 at 19:39 +0300, Tomer Maimon wrote:
> The NPCM7xx FIU controller driver gets its single clock with
> devm_clk_get_enabled(dev, NULL) and does not perform a named
> clock lookup. Drop the redundant clock-names properties from the
> FIU controller nodes so the DTS describes only the resources the
> driver actually uses.
The devicetree is a description of the hardware in the form documented
by the bindings. Generally it's not right to discuss Linux drivers
here: they're only relevant in the context of Linux, but the devicetree
binding governs devicetrees over multiple projects.
From a quick look it seems that these names are not described in the
corresponding binding, therefore no drivers should be using them and as
such they can (and should) be dropped. A driver would only be worth
mentioning if it did use the undocumented names (as that would be a
complication).
Can you please rework the description?
Andrew
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index a16450abea0e..83cd10b47273 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
> reg = <0xfb000000 0x1000>;
> reg-names = "control";
> clocks = <&clk NPCM7XX_CLK_SPI0>;
> - clock-names = "clk_spi0";
> status = "disabled";
> };
>
> @@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
> reg = <0xc0000000 0x1000>;
> reg-names = "control";
> clocks = <&clk NPCM7XX_CLK_SPI3>;
> - clock-names = "clk_spi3";
> pinctrl-names = "default";
> pinctrl-0 = <&spi3_pins>;
> status = "disabled";
> @@ -217,7 +215,6 @@ fiux: spi@fb001000 {
> reg = <0xfb001000 0x1000>;
> reg-names = "control";
> clocks = <&clk NPCM7XX_CLK_SPIX>;
> - clock-names = "clk_spix";
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-10 10:49 ` Andrew Jeffery
@ 2026-06-10 11:56 ` Tomer Maimon
2026-06-10 11:58 ` Andrew Jeffery
0 siblings, 1 reply; 11+ messages in thread
From: Tomer Maimon @ 2026-06-10 11:56 UTC (permalink / raw)
To: Andrew Jeffery
Cc: broonie, robh, krzk+dt, conor+dt, openbmc, linux-spi, devicetree,
linux-kernel, avifishman70, tali.perry1, venture, yuenn,
benjaminfair
On Wed, 10 Jun 2026 at 13:49, Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Tue, 2026-06-09 at 19:39 +0300, Tomer Maimon wrote:
> > The NPCM7xx FIU controller driver gets its single clock with
> > devm_clk_get_enabled(dev, NULL) and does not perform a named
> > clock lookup. Drop the redundant clock-names properties from the
> > FIU controller nodes so the DTS describes only the resources the
> > driver actually uses.
>
> The devicetree is a description of the hardware in the form documented
> by the bindings. Generally it's not right to discuss Linux drivers
> here: they're only relevant in the context of Linux, but the devicetree
> binding governs devicetrees over multiple projects.
>
> From a quick look it seems that these names are not described in the
> corresponding binding, therefore no drivers should be using them and as
> such they can (and should) be dropped. A driver would only be worth
> mentioning if it did use the undocumented names (as that would be a
> complication).
>
> Can you please rework the description?
do you mean change the description as follows
"
The NPCM7xx FIU controller nodes reference a single clock,
but the FIU binding does not describe their clock-names properties.
Drop the undocumented names so the DTS matches the binding.
"
>
> Andrew
>
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> > arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > index a16450abea0e..83cd10b47273 100644
> > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > @@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
> > reg = <0xfb000000 0x1000>;
> > reg-names = "control";
> > clocks = <&clk NPCM7XX_CLK_SPI0>;
> > - clock-names = "clk_spi0";
> > status = "disabled";
> > };
> >
> > @@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
> > reg = <0xc0000000 0x1000>;
> > reg-names = "control";
> > clocks = <&clk NPCM7XX_CLK_SPI3>;
> > - clock-names = "clk_spi3";
> > pinctrl-names = "default";
> > pinctrl-0 = <&spi3_pins>;
> > status = "disabled";
> > @@ -217,7 +215,6 @@ fiux: spi@fb001000 {
> > reg = <0xfb001000 0x1000>;
> > reg-names = "control";
> > clocks = <&clk NPCM7XX_CLK_SPIX>;
> > - clock-names = "clk_spix";
> > status = "disabled";
> > };
> >
Thanks,
Tomer
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-10 11:56 ` Tomer Maimon
@ 2026-06-10 11:58 ` Andrew Jeffery
2026-06-10 12:06 ` Tomer Maimon
0 siblings, 1 reply; 11+ messages in thread
From: Andrew Jeffery @ 2026-06-10 11:58 UTC (permalink / raw)
To: Tomer Maimon
Cc: broonie, robh, krzk+dt, conor+dt, openbmc, linux-spi, devicetree,
linux-kernel, avifishman70, tali.perry1, venture, yuenn,
benjaminfair
On Wed, 2026-06-10 at 14:56 +0300, Tomer Maimon wrote:
> On Wed, 10 Jun 2026 at 13:49, Andrew Jeffery
> <andrew@codeconstruct.com.au> wrote:
> >
> > On Tue, 2026-06-09 at 19:39 +0300, Tomer Maimon wrote:
> > > The NPCM7xx FIU controller driver gets its single clock with
> > > devm_clk_get_enabled(dev, NULL) and does not perform a named
> > > clock lookup. Drop the redundant clock-names properties from the
> > > FIU controller nodes so the DTS describes only the resources the
> > > driver actually uses.
> >
> > The devicetree is a description of the hardware in the form documented
> > by the bindings. Generally it's not right to discuss Linux drivers
> > here: they're only relevant in the context of Linux, but the devicetree
> > binding governs devicetrees over multiple projects.
> >
> > From a quick look it seems that these names are not described in the
> > corresponding binding, therefore no drivers should be using them and as
> > such they can (and should) be dropped. A driver would only be worth
> > mentioning if it did use the undocumented names (as that would be a
> > complication).
> >
> > Can you please rework the description?
> do you mean change the description as follows
> "
> The NPCM7xx FIU controller nodes reference a single clock,
> but the FIU binding does not describe their clock-names properties.
> Drop the undocumented names so the DTS matches the binding.
> "
That sounds reasonable to me.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names
2026-06-10 11:58 ` Andrew Jeffery
@ 2026-06-10 12:06 ` Tomer Maimon
0 siblings, 0 replies; 11+ messages in thread
From: Tomer Maimon @ 2026-06-10 12:06 UTC (permalink / raw)
To: Andrew Jeffery
Cc: broonie, robh, krzk+dt, conor+dt, openbmc, linux-spi, devicetree,
linux-kernel, avifishman70, tali.perry1, venture, yuenn,
benjaminfair
will send V5 soon with message modification
On Wed, 10 Jun 2026 at 14:58, Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Wed, 2026-06-10 at 14:56 +0300, Tomer Maimon wrote:
> > On Wed, 10 Jun 2026 at 13:49, Andrew Jeffery
> > <andrew@codeconstruct.com.au> wrote:
> > >
> > > On Tue, 2026-06-09 at 19:39 +0300, Tomer Maimon wrote:
> > > > The NPCM7xx FIU controller driver gets its single clock with
> > > > devm_clk_get_enabled(dev, NULL) and does not perform a named
> > > > clock lookup. Drop the redundant clock-names properties from the
> > > > FIU controller nodes so the DTS describes only the resources the
> > > > driver actually uses.
> > >
> > > The devicetree is a description of the hardware in the form documented
> > > by the bindings. Generally it's not right to discuss Linux drivers
> > > here: they're only relevant in the context of Linux, but the devicetree
> > > binding governs devicetrees over multiple projects.
> > >
> > > From a quick look it seems that these names are not described in the
> > > corresponding binding, therefore no drivers should be using them and as
> > > such they can (and should) be dropped. A driver would only be worth
> > > mentioning if it did use the undocumented names (as that would be a
> > > complication).
> > >
> > > Can you please rework the description?
> > do you mean change the description as follows
> > "
> > The NPCM7xx FIU controller nodes reference a single clock,
> > but the FIU binding does not describe their clock-names properties.
> > Drop the undocumented names so the DTS matches the binding.
> > "
>
> That sounds reasonable to me.
>
> Thanks,
>
> Andrew
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema
2026-06-09 16:39 [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Tomer Maimon
2026-06-09 16:39 ` [PATCH v4 1/3] arm: dts: nuvoton: npcm7xx: Drop bogus FIU memory reg-names Tomer Maimon
2026-06-09 16:39 ` [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names Tomer Maimon
@ 2026-06-09 16:39 ` Tomer Maimon
2026-06-10 7:20 ` Krzysztof Kozlowski
2026-06-11 18:56 ` (subset) [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Mark Brown
3 siblings, 1 reply; 11+ messages in thread
From: Tomer Maimon @ 2026-06-09 16:39 UTC (permalink / raw)
To: andrew, broonie, robh, krzk+dt, conor+dt
Cc: openbmc, linux-spi, devicetree, linux-kernel, avifishman70,
tmaimon77, tali.perry1, venture, yuenn, benjaminfair
Convert the Nuvoton NPCM FIU binding to DT schema format.
Document the required control registers and the optional direct-
mapped flash window separately, matching the driver behavior
when the direct mapping is not described.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
.../bindings/spi/nuvoton,npcm-fiu.txt | 58 ------------
.../bindings/spi/nuvoton,npcm750-fiu.yaml | 93 +++++++++++++++++++
2 files changed, 93 insertions(+), 58 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
deleted file mode 100644
index fb38e96d395f..000000000000
--- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
+++ /dev/null
@@ -1,58 +0,0 @@
-* Nuvoton FLASH Interface Unit (FIU) SPI Controller
-
-NPCM FIU supports single, dual and quad communication interface.
-
-The NPCM7XX supports three FIU modules,
-FIU0 and FIUx supports two chip selects,
-FIU3 support four chip select.
-
-The NPCM8XX supports four FIU modules,
-FIU0 and FIUx supports two chip selects,
-FIU1 and FIU3 supports four chip selects.
-
-Required properties:
- - compatible : "nuvoton,npcm750-fiu" for Poleg NPCM7XX BMC
- "nuvoton,npcm845-fiu" for Arbel NPCM8XX BMC
- - #address-cells : should be 1.
- - #size-cells : should be 0.
- - reg : the first contains the register location and length,
- the second contains the memory mapping address and length
- - reg-names: Should contain the reg names "control" and "memory"
- - clocks : phandle of FIU reference clock.
-
-Required properties in case the pins can be muxed:
- - pinctrl-names : a pinctrl state named "default" must be defined.
- - pinctrl-0 : phandle referencing pin configuration of the device.
-
-Optional property:
- - nuvoton,spix-mode: enable spix-mode for an expansion bus to an ASIC or CPLD.
-
-Aliases:
-- All the FIU controller nodes should be represented in the aliases node using
- the following format 'fiu{n}' where n is a unique number for the alias.
- In the NPCM7XX BMC:
- fiu0 represent fiu 0 controller
- fiu1 represent fiu 3 controller
- fiu2 represent fiu x controller
-
- In the NPCM8XX BMC:
- fiu0 represent fiu 0 controller
- fiu1 represent fiu 1 controller
- fiu2 represent fiu 3 controller
- fiu3 represent fiu x controller
-
-Example:
-fiu3: spi@c00000000 {
- compatible = "nuvoton,npcm750-fiu";
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
- reg-names = "control", "memory";
- clocks = <&clk NPCM7XX_CLK_AHB>;
- pinctrl-names = "default";
- pinctrl-0 = <&spi3_pins>;
- flash@0 {
- ...
- };
-};
-
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml
new file mode 100644
index 000000000000..965904a98785
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/nuvoton,npcm750-fiu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nuvoton NPCM Flash Interface Unit (FIU) SPI Controller
+
+maintainers:
+ - Tomer Maimon <tmaimon77@gmail.com>
+
+allOf:
+ - $ref: /schemas/spi/spi-controller.yaml#
+
+description: |
+ NPCM FIU supports single, dual and quad communication interface.
+
+ The NPCM7XX supports three FIU modules:
+ FIU0 and FIUx support two chip selects
+ FIU3 supports four chip selects.
+
+ The NPCM8XX supports four FIU modules:
+ FIU0 and FIUx support two chip selects
+ FIU1 and FIU3 support four chip selects.
+
+ The FIU control register block is always required. The direct-mapped
+ flash window is optional because the controller can still access flash
+ through the UMA path when that mapping is not described.
+
+ Alias convention:
+ The '/aliases' node should define:
+ For NPCM7xx: fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux;
+ For NPCM8xx: fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux; fiu3=&fiu1;
+
+properties:
+ compatible:
+ enum:
+ - nuvoton,npcm750-fiu # Poleg NPCM7XX
+ - nuvoton,npcm845-fiu # Arbel NPCM8XX
+
+ reg:
+ description:
+ The first resource is the FIU control register block. An optional second
+ resource describes the direct-mapped flash window used for direct
+ read/write accesses.
+ minItems: 1
+ items:
+ - description: FIU control registers
+ - description: Memory-mapped flash contents
+
+ reg-names:
+ description:
+ Resource names for the control registers and optional direct-mapped
+ flash window.
+ minItems: 1
+ items:
+ - const: control
+ - const: memory
+
+ clocks:
+ maxItems: 1
+ description: FIU reference clock.
+
+ nuvoton,spix-mode:
+ type: boolean
+ description: Enable SPIX mode for an expansion bus to an ASIC or CPLD.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h>
+ spi@fb000000 {
+ compatible = "nuvoton,npcm750-fiu";
+ reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
+ reg-names = "control", "memory";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clk NPCM7XX_CLK_SPI0>;
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v4 3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema
2026-06-09 16:39 ` [PATCH v4 3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema Tomer Maimon
@ 2026-06-10 7:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-10 7:20 UTC (permalink / raw)
To: Tomer Maimon
Cc: andrew, broonie, robh, krzk+dt, conor+dt, openbmc, linux-spi,
devicetree, linux-kernel, avifishman70, tali.perry1, venture,
yuenn, benjaminfair
On Tue, Jun 09, 2026 at 07:39:19PM +0300, Tomer Maimon wrote:
> Convert the Nuvoton NPCM FIU binding to DT schema format.
>
> Document the required control registers and the optional direct-
> mapped flash window separately, matching the driver behavior
> when the direct mapping is not described.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../bindings/spi/nuvoton,npcm-fiu.txt | 58 ------------
> .../bindings/spi/nuvoton,npcm750-fiu.yaml | 93 +++++++++++++++++++
> 2 files changed, 93 insertions(+), 58 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
> create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion
2026-06-09 16:39 [PATCH v4 0/3] Nuvoton NPCM FIU DTS fixes and binding conversion Tomer Maimon
` (2 preceding siblings ...)
2026-06-09 16:39 ` [PATCH v4 3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema Tomer Maimon
@ 2026-06-11 18:56 ` Mark Brown
3 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2026-06-11 18:56 UTC (permalink / raw)
To: andrew, robh, krzk+dt, conor+dt, Tomer Maimon
Cc: openbmc, linux-spi, devicetree, linux-kernel, avifishman70,
tali.perry1, venture, yuenn, benjaminfair
On Tue, 09 Jun 2026 19:39:16 +0300, Tomer Maimon wrote:
> Nuvoton NPCM FIU DTS fixes and binding conversion
>
> This series fixes the in-tree NPCM7xx FIU controller nodes so their
> resources match what the DTS actually describes, and converts the legacy
> Nuvoton NPCM FIU binding to YAML DT schema.
>
> Patch 1 drops the bogus "memory" entry from reg-names on the NPCM7xx FIU
> nodes.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.2
Thanks!
[3/3] spi: dt-bindings: nuvoton,npcm750-fiu: Convert to DT schema
https://git.kernel.org/broonie/misc/c/3da90b29241d
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 11+ messages in thread