From: "xhao@linux.alibaba.com" <xhao@linux.alibaba.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sven Van Asbroeck <thesven73@gmail.com>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v1] spi: fix client driver can't register success when use GPIO as CS
Date: Sat, 8 May 2021 09:22:56 +0800 [thread overview]
Message-ID: <489967db-128c-a52a-e36b-15d116173bb2@linux.alibaba.com> (raw)
In-Reply-To: <CACRpkdZeKGP6Z8h3GaQ0=EA8mx+yRqzwZaQ5vDJrB4GiYLa26w@mail.gmail.com>
在 2021/5/8 上午5:33, Linus Walleij 写道:
> On Fri, May 7, 2021 at 9:11 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>
>> It can’t be done due to differences of the expectations from them.
>> Your patch breaks OF as far as I understand. Linus?
> It looks to me like it would break OF.
>
> commit 766c6b63aa044e84b045803b40b14754d69a2a1d
> "spi: fix client driver breakages when using GPIO descriptors"
> passes enable1 to gpiod_set_value_cansleep() expecting
> gpiolib to handle polarity.
>
> If this should be changed, Sven van Asbroeck really needs
> to look at it first.
>
> But I think Andy's approach is the best.
Ok, agree, i check the relative patches, They do respond to different
situations，
Andy，When do you send out your patch to fix this problem？
>
> Yours,
> Linus Walleij
--
Best Regards!
Xin Hao
next prev parent reply other threads:[~2021-05-08 1:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 11:49 [PATCH v1] spi: fix client driver can't register success when use GPIO as CS Xin Hao
2021-05-06 12:30 ` Linus Walleij
2021-05-06 14:16 ` Andy Shevchenko
2021-05-07 1:55 ` Xin Hao
[not found] ` <CAHp75Vev1D5+QWyGCm+HgpdAyT4Uq_OAp7dCemVf9Cdvoay=Og@mail.gmail.com>
[not found] ` <6bd8f178-51a2-3f45-8a16-80fdd4a3ed8e@linux.alibaba.com>
[not found] ` <CAHp75Vfh+jqNLLbwWDe8pi1dQafnNFHak1Hk=5Cw3J+kJX9r3Q@mail.gmail.com>
2021-05-07 21:33 ` Linus Walleij
2021-05-08 1:22 ` xhao [this message]
2021-05-08 2:36 ` Sven Van Asbroeck
2021-05-08 11:38 ` Sven Van Asbroeck
[not found] ` <CAHp75VfD5kEnjvvRWUJwpmFaWksnnTf_ewBNDsxz3W3kQMUv+w@mail.gmail.com>
2021-05-08 11:46 ` Sven Van Asbroeck
2021-05-08 12:48 ` Sven Van Asbroeck
2021-05-10 11:36 ` Andy Shevchenko
2021-05-10 13:56 ` Sven Van Asbroeck
2021-05-10 14:01 ` Andy Shevchenko
2021-05-10 14:27 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489967db-128c-a52a-e36b-15d116173bb2@linux.alibaba.com \
--to=xhao@linux.alibaba.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox