From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@altera.com>
Cc: Mark Brown <broonie@kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"Gerlach, Matthew" <matthew.gerlach@altera.com>
Subject: Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
Date: Tue, 1 Jul 2025 06:40:48 +0300 [thread overview]
Message-ID: <612f64eb-ab8c-43cd-9f6a-e913cd5aecb6@suswa.mountain> (raw)
In-Reply-To: <DM6PR03MB5017D9C650820B9A5C63C6ACC641A@DM6PR03MB5017.namprd03.prod.outlook.com>
On Tue, Jul 01, 2025 at 12:39:24AM +0000, Romli, Khairul Anuar wrote:
> > On Mon, Jun 30, 2025 at 05:11:56PM +0800,
> > khairul.anuar.romli@altera.com wrote:
> > > From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> > >
> > > Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> > > during failure cleanup. Ensure proper resource freeing on the success
> > > path when operating in cqspi->use_direct_mode, preventing leaks and
> > > improving stability.
> > >
> > > Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> >
> > Thanks.
> >
> > Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> >
> > Mark asked me to fix this and I wrote a fix but apparently I didn't hit send
> > because it's still in my outbox. Sorry about that. :(
> >
> > regards,
> > dan carpenter
>
> Sorry for sending the fix on your behalf.
No no. You did the right thing. It's me who messed up.
regards,
dan carpenter
next prev parent reply other threads:[~2025-07-01 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1751274389.git.khairul.anuar.romli@altera.com>
2025-06-30 9:11 ` [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths khairul.anuar.romli
2025-06-30 10:40 ` Santhosh Kumar K
2025-06-30 18:00 ` Dan Carpenter
2025-07-01 0:39 ` Romli, Khairul Anuar
2025-07-01 3:40 ` Dan Carpenter [this message]
2025-07-01 22:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612f64eb-ab8c-43cd-9f6a-e913cd5aecb6@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=broonie@kernel.org \
--cc=khairul.anuar.romli@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox