Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: khairul.anuar.romli@altera.com
Cc: Mark Brown <broonie@kernel.org>,
	"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
Date: Mon, 30 Jun 2025 21:00:07 +0300	[thread overview]
Message-ID: <9f26f205-756e-4fcd-912e-bf73167be21d@suswa.mountain> (raw)
In-Reply-To: <89765a2b94f047ded4f14babaefb7ef92ba07cb2.1751274389.git.khairul.anuar.romli@altera.com>

On Mon, Jun 30, 2025 at 05:11:56PM +0800, khairul.anuar.romli@altera.com wrote:
> From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> 
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Thanks.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

Mark asked me to fix this and I wrote a fix but apparently I didn't
hit send because it's still in my outbox.  Sorry about that.  :(

regards,
dan carpenter


  parent reply	other threads:[~2025-06-30 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1751274389.git.khairul.anuar.romli@altera.com>
2025-06-30  9:11 ` [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths khairul.anuar.romli
2025-06-30 10:40   ` Santhosh Kumar K
2025-06-30 18:00   ` Dan Carpenter [this message]
2025-07-01  0:39     ` Romli, Khairul Anuar
2025-07-01  3:40       ` Dan Carpenter
2025-07-01 22:15   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f26f205-756e-4fcd-912e-bf73167be21d@suswa.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=broonie@kernel.org \
    --cc=khairul.anuar.romli@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthew.gerlach@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox