From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
William Zhang <william.zhang@broadcom.com>
Cc: Kursad Oney <kursad.oney@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: bcm63xx-hsspi: fix error code in probe
Date: Wed, 15 Feb 2023 10:03:44 -0800 [thread overview]
Message-ID: <8ea9e441-1f18-c509-70b0-94a9f1b803dd@gmail.com> (raw)
In-Reply-To: <Y+zmoGH6LubPhiI0@kili>
On 2/15/23 06:05, Dan Carpenter wrote:
> This code accidentally returns success instead of a negative error code.
>
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-02-15 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:05 [PATCH] spi: bcm63xx-hsspi: fix error code in probe Dan Carpenter
2023-02-15 18:01 ` William Zhang
2023-02-15 18:03 ` Florian Fainelli [this message]
2023-02-16 13:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea9e441-1f18-c509-70b0-94a9f1b803dd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=error27@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-spi@vger.kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox