From: William Zhang <william.zhang@broadcom.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Kursad Oney <kursad.oney@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: bcm63xx-hsspi: fix error code in probe
Date: Wed, 15 Feb 2023 10:01:07 -0800 [thread overview]
Message-ID: <c54b2da0-8c53-1ad9-b9ef-f385b46a2dee@broadcom.com> (raw)
In-Reply-To: <Y+zmoGH6LubPhiI0@kili>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On 02/15/2023 06:05 AM, Dan Carpenter wrote:
> This code accidentally returns success instead of a negative error code.
>
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 1e9e906d297c..e481c8d5e5d6 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -847,7 +847,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>
> pm_runtime_enable(&pdev->dev);
>
> - if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
> + ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
> + if (ret) {
> dev_err(&pdev->dev, "couldn't register sysfs group\n");
> goto out_pm_disable;
> }
>
Reviewed-by: William Zhang <william.zhang@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2023-02-15 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:05 [PATCH] spi: bcm63xx-hsspi: fix error code in probe Dan Carpenter
2023-02-15 18:01 ` William Zhang [this message]
2023-02-15 18:03 ` Florian Fainelli
2023-02-16 13:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c54b2da0-8c53-1ad9-b9ef-f385b46a2dee@broadcom.com \
--to=william.zhang@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=error27@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox