From: Mark Brown <broonie@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Krishna Yarlagadda <kyarlagadda@nvidia.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [Patch V5 2/3] tpm_tis-spi: Support hardware wait polling
Date: Wed, 1 Mar 2023 12:37:27 +0000 [thread overview]
Message-ID: <Y/9HB/KF2Kjkihkg@sirena.org.uk> (raw)
In-Reply-To: <Y/9EwTtmxcVBjiHz@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Wed, Mar 01, 2023 at 08:27:45AM -0400, Jason Gunthorpe wrote:
> On Wed, Mar 01, 2023 at 11:56:53AM +0000, Krishna Yarlagadda wrote:
> > TPM device connected behind half duplex controller can only work
> > this way. So, no additional flag needed to check.
> Just because a DT hooks it up this way doesn't mean the kernel driver
> can support it, eg support hasn't been implemented in an older SPI
> driver or something.
> If the failure mode is anything other than the TPM doesn't probe we
> will need to check for support.
It's not like these buses are hot pluggable - someone would have to
design and manufacture a board which doesn't work. It's probably
reasonable for this to fail with the SPI subsystem saying it can't
support things when the operation is tried.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-01 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 12:06 [Patch V5 0/3] Tegra TPM driver with HW flow control Krishna Yarlagadda
2023-02-27 12:07 ` [Patch V5 1/3] spi: Add TPM HW flow flag Krishna Yarlagadda
2023-02-27 12:07 ` [Patch V5 2/3] tpm_tis-spi: Support hardware wait polling Krishna Yarlagadda
2023-02-28 2:36 ` Jarkko Sakkinen
2023-02-28 3:32 ` Krishna Yarlagadda
2023-03-01 23:17 ` Jarkko Sakkinen
2023-02-28 12:28 ` Jason Gunthorpe
2023-03-01 11:56 ` Krishna Yarlagadda
2023-03-01 12:27 ` Jason Gunthorpe
2023-03-01 12:37 ` Mark Brown [this message]
2023-03-01 13:39 ` Jason Gunthorpe
2023-03-01 13:45 ` Mark Brown
2023-03-01 14:09 ` Thierry Reding
2023-03-01 15:38 ` Jason Gunthorpe
2023-02-27 12:07 ` [Patch V5 3/3] spi: tegra210-quad: Enable TPM " Krishna Yarlagadda
2023-02-28 2:28 ` [Patch V5 0/3] Tegra TPM driver with HW flow control Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9HB/KF2Kjkihkg@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox