From: Mark Brown <broonie@kernel.org>
To: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Cc: greg.malysa@timesys.com,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: cadence-quadspi: Add upper limit safety check to baudrate divisor
Date: Thu, 24 Nov 2022 11:40:20 +0000 [thread overview]
Message-ID: <Y39YJL02jFbkEMqw@sirena.org.uk> (raw)
In-Reply-To: <20221123211705.126900-1-nathan.morrison@timesys.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Wed, Nov 23, 2022 at 04:17:05PM -0500, Nathan Barrett-Morrison wrote:
> + /* Maximum baud divisor */
> + if (div > CQSPI_REG_CONFIG_BAUD_MASK)
> + div = CQSPI_REG_CONFIG_BAUD_MASK;
This will fix the overflow of the divisor but it means that we'll be
generating a faster clock than the device asked for which might lead to
problems. We should at the very least warn, though returning an error
would be safer. Ideally we'd be able to adjust the input clock to the
SPI controller to allow us to divide out an appropriate clock but that's
more disruptive.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-11-24 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 21:17 [PATCH] spi: cadence-quadspi: Add upper limit safety check to baudrate divisor Nathan Barrett-Morrison
2022-11-24 6:46 ` Dhruva Gole
2022-11-24 11:35 ` Mark Brown
2022-11-24 12:27 ` Dhruva Gole
2022-11-24 12:41 ` Mark Brown
2022-11-24 11:40 ` Mark Brown [this message]
2022-11-24 11:53 ` Nathan Barrett-Morrison
2022-11-24 12:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y39YJL02jFbkEMqw@sirena.org.uk \
--to=broonie@kernel.org \
--cc=greg.malysa@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nathan.morrison@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox