Linux SPI subsystem development
 help / color / mirror / Atom feed
* [PATCH 0/2] spi: offload: extra headers
@ 2025-02-10 23:16 David Lechner
  2025-02-10 23:16 ` [PATCH 1/2] spi: offload: types: include linux/bits.h David Lechner
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: David Lechner @ 2025-02-10 23:16 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, linux-kernel, David Lechner, Andy Shevchenko

Following up from some late feedback, a couple patches adding extra
headers to a few SPI offload files.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
David Lechner (2):
      spi: offload: types: include linux/bits.h
      spi: spi-offload-trigger-pwm: add extra headers

 drivers/spi/spi-offload-trigger-pwm.c | 9 ++++++++-
 include/linux/spi/offload/types.h     | 1 +
 2 files changed, 9 insertions(+), 1 deletion(-)
---
base-commit: d15cc2db846f73920688c045be6b4c782b68d058
change-id: 20250210-spi-offload-extra-headers-86be29913fe5

Best regards,
-- 
David Lechner <dlechner@baylibre.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] spi: offload: types: include linux/bits.h
  2025-02-10 23:16 [PATCH 0/2] spi: offload: extra headers David Lechner
@ 2025-02-10 23:16 ` David Lechner
  2025-02-10 23:16 ` [PATCH 2/2] spi: spi-offload-trigger-pwm: add extra headers David Lechner
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: David Lechner @ 2025-02-10 23:16 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, linux-kernel, David Lechner, Andy Shevchenko

Add #include <linux/bits.h> to linux/spi/offload/types.h since this
file uses the BIT macro.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 include/linux/spi/offload/types.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/spi/offload/types.h b/include/linux/spi/offload/types.h
index 86d0e8cb9495bb43e177378b2041067de8ea8786..6f78923478713aa3c4fc03d7d47b768ed1d52682 100644
--- a/include/linux/spi/offload/types.h
+++ b/include/linux/spi/offload/types.h
@@ -7,6 +7,7 @@
 #ifndef __LINUX_SPI_OFFLOAD_TYPES_H
 #define __LINUX_SPI_OFFLOAD_TYPES_H
 
+#include <linux/bits.h>
 #include <linux/types.h>
 
 struct device;

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] spi: spi-offload-trigger-pwm: add extra headers
  2025-02-10 23:16 [PATCH 0/2] spi: offload: extra headers David Lechner
  2025-02-10 23:16 ` [PATCH 1/2] spi: offload: types: include linux/bits.h David Lechner
@ 2025-02-10 23:16 ` David Lechner
  2025-02-11  9:34 ` [PATCH 0/2] spi: offload: " Andy Shevchenko
  2025-02-11 19:13 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: David Lechner @ 2025-02-10 23:16 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, linux-kernel, David Lechner, Andy Shevchenko

Add additional headers used in this driver. This is better than relying
on implicit includes via other unrelated headers.

Also sort the existing includes while doing so.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/spi/spi-offload-trigger-pwm.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-offload-trigger-pwm.c b/drivers/spi/spi-offload-trigger-pwm.c
index b26d4437c589052709a8206f8314ffd08355870e..805ed41560df090d85a8547b59f122cf2e3941a2 100644
--- a/drivers/spi/spi-offload-trigger-pwm.c
+++ b/drivers/spi/spi-offload-trigger-pwm.c
@@ -6,10 +6,17 @@
  * Generic PWM trigger for SPI offload.
  */
 
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/math.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
 #include <linux/pwm.h>
-#include <linux/mod_devicetable.h>
 #include <linux/spi/offload/provider.h>
+#include <linux/spi/offload/types.h>
+#include <linux/time.h>
 #include <linux/types.h>
 
 struct spi_offload_trigger_pwm_state {

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] spi: offload: extra headers
  2025-02-10 23:16 [PATCH 0/2] spi: offload: extra headers David Lechner
  2025-02-10 23:16 ` [PATCH 1/2] spi: offload: types: include linux/bits.h David Lechner
  2025-02-10 23:16 ` [PATCH 2/2] spi: spi-offload-trigger-pwm: add extra headers David Lechner
@ 2025-02-11  9:34 ` Andy Shevchenko
  2025-02-11 19:13 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2025-02-11  9:34 UTC (permalink / raw)
  To: David Lechner; +Cc: Mark Brown, linux-spi, linux-kernel

On Mon, Feb 10, 2025 at 05:16:13PM -0600, David Lechner wrote:
> Following up from some late feedback, a couple patches adding extra
> headers to a few SPI offload files.

For both,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] spi: offload: extra headers
  2025-02-10 23:16 [PATCH 0/2] spi: offload: extra headers David Lechner
                   ` (2 preceding siblings ...)
  2025-02-11  9:34 ` [PATCH 0/2] spi: offload: " Andy Shevchenko
@ 2025-02-11 19:13 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2025-02-11 19:13 UTC (permalink / raw)
  To: David Lechner; +Cc: linux-spi, linux-kernel, Andy Shevchenko

On Mon, 10 Feb 2025 17:16:13 -0600, David Lechner wrote:
> Following up from some late feedback, a couple patches adding extra
> headers to a few SPI offload files.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: offload: types: include linux/bits.h
      commit: fcd7ace9a725ae034ff9f24cb94c9fe12a1f02da
[2/2] spi: spi-offload-trigger-pwm: add extra headers
      commit: ff4d4158ef9143327a42f7be4298751cb0d1be69

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-02-11 19:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-10 23:16 [PATCH 0/2] spi: offload: extra headers David Lechner
2025-02-10 23:16 ` [PATCH 1/2] spi: offload: types: include linux/bits.h David Lechner
2025-02-10 23:16 ` [PATCH 2/2] spi: spi-offload-trigger-pwm: add extra headers David Lechner
2025-02-11  9:34 ` [PATCH 0/2] spi: offload: " Andy Shevchenko
2025-02-11 19:13 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox