Re: [PATCH v3] spi: cadence-xspi: Support 32bit and 64bit slave dma interface

[Jisheng Zhang <jszhang@kernel.org>]

On Wed, Jun 03, 2026 at 09:20:29AM +0100, Mark Brown wrote:
> On Wed, Jun 03, 2026 at 07:58:25AM +0800, Jisheng Zhang wrote:
> 
> > +	} else {
> > +		if (IS_ALIGNED((uintptr_t)src, 8) && IS_ALIGNED((uintptr_t)buf, 8)) {
> > +			readsq(src, buf, len >> 3);
> 
> readsq() and writesq() are only defined under CONFIG_64BIT AFAICT, but
> the driver will build on 32 bit.  We need to configure out this option
> on 32 bit architectures.

Currently, the cadence-xspi has depended on 64BIT, the dependency was
introduced by commit d58ecc54bb09 ("spi: cadence: Add 64BIT Kconfig
dependency") for marvell sdma handling. So we have two choices:

A. guard the marvell sdma handling with CONFIG_64BIT, and remove the
above hardcoded dependency, then introduce proper readsq/writesq
handling.

B. keep the 64BIT dependency, and review the merge this patch as is.

Which do you prefer? I'll cook newer version if you prefer option A.

Thanks