Re: [PATCH v4] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS

["M.samet Duman" <dumanmehmetsamet@icloud.com>]

A correction coming so quickly... I've only just started my day, and this is  4th v4.

--
Samet

> 2026. 5. 13. 오후 1:39, Greg KH <gregkh@linuxfoundation.org> 작성:
> 
> On Wed, May 13, 2026 at 08:59:48AM +0000, Harshit Shaw wrote:
>> Replace direct device_create_file() calls with the correct
>> ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
>> driver structure so the driver core automatically adds and removes
>> the sysfs attributes when a device is bound or unbound.
>> 
>> Signed-off-by: Harshit Shaw <shawharshit116@gmail.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>> ---
>> v4: Fix build error - add extern declaration of fbtft_groups in
>>    fbtft.h so all drivers using FBTFT_REGISTER_DRIVER macro can
>>    see the symbol
>> v3: Remove stray blank line in fbtft_attrs[] array
>> v2: - Use DEVICE_ATTR_RW() macro instead of DEVICE_ATTR()
>>    - Move DEVICE_ATTR_RW() definitions closer to their callbacks
>>    - Remove trailing comma after NULL in attribute array
>>    - Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver
>>      structure as suggested by Greg KH and Andy Shevchenko
>>    - Compile tested with: make M=drivers/staging/fbtft modules
> 
> I see too many v4 versions on the list for there really to be just 1 v4
> :(
> 
> Please wait a bit, take some time, and resubmit a new version after a
> few days making sure it's all correct.  There is no rush or deadline
> here.
> 
> thanks,
> 
> greg k-h
>