From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Harshit Shaw <shawharshit116@gmail.com>
Cc: gregkh@linuxfoundation.org, error27@gmail.com, deller@gmx.de,
chintanlike@gmail.com, tzimmermann@suse.de,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
Date: Wed, 13 May 2026 14:20:54 +0300 [thread overview]
Message-ID: <agRelnE-crnLDuvc@ashevche-desk.local> (raw)
In-Reply-To: <20260513064257.1238-1-shawharshit116@gmail.com>
On Wed, May 13, 2026 at 06:42:57AM +0000, Harshit Shaw wrote:
> Replace direct device_create_file() calls with the correct
> ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
> driver structure so the driver core automatically adds and removes
> the sysfs attributes when a device is bound or unbound.
...
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I need to withdraw this tag. Please, compile the code before sending.
You may not use ATTRIBUTE_GROUPS() in conjunction with extern.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-13 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 6:42 [PATCH v4] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Harshit Shaw
2026-05-13 7:12 ` Greg KH
2026-05-13 11:20 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 8:59 Harshit Shaw
2026-05-13 10:37 ` Greg KH
2026-05-13 10:53 ` M.samet Duman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agRelnE-crnLDuvc@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=chintanlike@gmail.com \
--cc=deller@gmx.de \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=shawharshit116@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox