From: Dan Carpenter <dan.carpenter@linaro.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
Larry.Finger@lwfinger.net, wlanfae@realtek.com, mikem@ring3k.org,
seanm@seanm.ca, linux-staging@lists.linux.dev
Subject: Re: [PATCH -next v2 0/3] staging: rtl8192e: Do not call kfree_skb() under spin_lock_irqsave()
Date: Tue, 5 Sep 2023 15:16:34 +0300 [thread overview]
Message-ID: <1ec0ca03-c8e5-4e6e-8838-25a3b6bd2d1e@kadam.mountain> (raw)
In-Reply-To: <45f6dbe0-e603-7c31-6d6c-04083e595d7d@gmail.com>
On Fri, Aug 25, 2023 at 07:47:44AM +0200, Philipp Hortmann wrote:
> On 8/25/23 03:52, Jinjie Ruan wrote:
> > It is not allowed to call kfree_skb() from hardware interrupt
> > context or with interrupts being disabled. This patchset is
> > trying to use dev_kfree_skb_irq() or add all skb to a free list, then
> > free them after spin_unlock_irqrestore() at once.
> >
> > Changes in v2:
> > - Combine the three patches into one patch set.
> > - Update the commit message and subject prefix.
> >
> > Jinjie Ruan (3):
> > staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of
> > kfree_skb() under spin_lock_irqsave()
> > staging: rtl8192e: rtl_core: Do not call kfree_skb() under
> > spin_lock_irqsave() for _rtl92e_irq()
> > Staging: rtl8192e: rtllib_softmac: Do not call kfree_skb() under
> > spin_lock_irqsave()
> >
> > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 24 ++++++++++++--------
> > drivers/staging/rtl8192e/rtllib_softmac.c | 6 ++++-
> > 2 files changed, 19 insertions(+), 11 deletions(-)
> >
>
> Patch number 01 is missing. Patch number 2 and 3 are OK
I recieved it. It's there on lore. But I too am having some issues
with a bunch of dropped patches recently. I don't know what caused it.
https://lore.kernel.org/all/20230825015213.2697347-2-ruanjinjie@huawei.com/
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-05 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 1:52 [PATCH -next v2 0/3] staging: rtl8192e: Do not call kfree_skb() under spin_lock_irqsave() Jinjie Ruan
2023-08-25 1:52 ` [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of " Jinjie Ruan
2023-09-13 8:34 ` Greg KH
2023-09-14 2:00 ` Ruan Jinjie
2023-08-25 1:52 ` [PATCH -next v2 2/3] staging: rtl8192e: rtl_core: Do not call kfree_skb() under spin_lock_irqsave() for _rtl92e_irq() Jinjie Ruan
2023-08-25 1:52 ` [PATCH -next v2 3/3] Staging: rtl8192e: rtllib_softmac: Do not call kfree_skb() under spin_lock_irqsave() Jinjie Ruan
2023-08-25 5:47 ` [PATCH -next v2 0/3] staging: rtl8192e: " Philipp Hortmann
2023-09-05 12:16 ` Dan Carpenter [this message]
2023-09-05 11:59 ` Dan Carpenter
2023-09-14 2:01 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec0ca03-c8e5-4e6e-8838-25a3b6bd2d1e@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=mikem@ring3k.org \
--cc=philipp.g.hortmann@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=seanm@seanm.ca \
--cc=straube.linux@gmail.com \
--cc=wlanfae@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox