From: Greg KH <gregkh@linuxfoundation.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: philipp.g.hortmann@gmail.com, straube.linux@gmail.com,
Larry.Finger@lwfinger.net, wlanfae@realtek.com, mikem@ring3k.org,
seanm@seanm.ca, linux-staging@lists.linux.dev
Subject: Re: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
Date: Wed, 13 Sep 2023 10:34:23 +0200 [thread overview]
Message-ID: <2023091352-mouth-escapist-6eb4@gregkh> (raw)
In-Reply-To: <20230825015213.2697347-2-ruanjinjie@huawei.com>
On Fri, Aug 25, 2023 at 09:52:11AM +0800, Jinjie Ruan wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with hardware interrupts being disabled.
Why not? Seems to work so far :)
Are you fixing up all of the normal network drivers for this first?
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-13 8:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 1:52 [PATCH -next v2 0/3] staging: rtl8192e: Do not call kfree_skb() under spin_lock_irqsave() Jinjie Ruan
2023-08-25 1:52 ` [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of " Jinjie Ruan
2023-09-13 8:34 ` Greg KH [this message]
2023-09-14 2:00 ` Ruan Jinjie
2023-08-25 1:52 ` [PATCH -next v2 2/3] staging: rtl8192e: rtl_core: Do not call kfree_skb() under spin_lock_irqsave() for _rtl92e_irq() Jinjie Ruan
2023-08-25 1:52 ` [PATCH -next v2 3/3] Staging: rtl8192e: rtllib_softmac: Do not call kfree_skb() under spin_lock_irqsave() Jinjie Ruan
2023-08-25 5:47 ` [PATCH -next v2 0/3] staging: rtl8192e: " Philipp Hortmann
2023-09-05 12:16 ` Dan Carpenter
2023-09-05 11:59 ` Dan Carpenter
2023-09-14 2:01 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091352-mouth-escapist-6eb4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-staging@lists.linux.dev \
--cc=mikem@ring3k.org \
--cc=philipp.g.hortmann@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=seanm@seanm.ca \
--cc=straube.linux@gmail.com \
--cc=wlanfae@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox