[PATCH] staging: mt7621-dts: fix cpuintc and fixedregulator dtc warnings, fix xhci

[PATCH] staging: mt7621-dts: fix cpuintc and fixedregulator dtc warnings, fix xhci

[Arınç ÜNAL]

Fix the cpuintc and fixedregulator dtc warnings:

Warning (unit_address_vs_reg): /cpuintc@0: node has a unit name, but no reg property
Warning (unit_address_vs_reg): /fixedregulator@0: node has a unit name, but no reg property
Warning (unit_address_vs_reg): /fixedregulator@1: node has a unit name, but no reg property
Warning (unique_unit_address): /cpuintc@0: duplicate unit-address (also used in node /fixedregulator@0)

Remove the unnecessary status = "okay" property from the xhci node.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 drivers/staging/mt7621-dts/mt7621.dtsi | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
index 4da20da243e6..3222684915ac 100644
--- a/drivers/staging/mt7621-dts/mt7621.dtsi
+++ b/drivers/staging/mt7621-dts/mt7621.dtsi
@@ -26,7 +26,7 @@ cpu@1 {
 		};
 	};
 
-	cpuintc: cpuintc@0 {
+	cpuintc: cpuintc {
 		#address-cells = <0>;
 		#interrupt-cells = <1>;
 		interrupt-controller;
@@ -38,7 +38,7 @@ aliases {
 	};
 
 
-	mmc_fixed_3v3: fixedregulator@0 {
+	mmc_fixed_3v3: regulator-3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "mmc_power";
 		regulator-min-microvolt = <3300000>;
@@ -47,7 +47,7 @@ mmc_fixed_3v3: fixedregulator@0 {
 		regulator-always-on;
 	};
 
-	mmc_fixed_1v8_io: fixedregulator@1 {
+	mmc_fixed_1v8_io: regulator-1v8 {
 		compatible = "regulator-fixed";
 		regulator-name = "mmc_io";
 		regulator-min-microvolt = <1800000>;
@@ -263,8 +263,6 @@ sdhci: sdhci@1e130000 {
 	};
 
 	xhci: xhci@1e1c0000 {
-		status = "okay";
-
 		compatible = "mediatek,mt8173-xhci";
 		reg = <0x1e1c0000 0x1000
 		       0x1e1d0700 0x0100>;
-- 
2.25.1

Re: [PATCH] staging: mt7621-dts: fix cpuintc and fixedregulator dtc warnings, fix xhci

[Sergio Paracuellos]

On Sat, Mar 12, 2022 at 10:22 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Fix the cpuintc and fixedregulator dtc warnings:
>
> Warning (unit_address_vs_reg): /cpuintc@0: node has a unit name, but no reg property
> Warning (unit_address_vs_reg): /fixedregulator@0: node has a unit name, but no reg property
> Warning (unit_address_vs_reg): /fixedregulator@1: node has a unit name, but no reg property
> Warning (unique_unit_address): /cpuintc@0: duplicate unit-address (also used in node /fixedregulator@0)
>
> Remove the unnecessary status = "okay" property from the xhci node.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  drivers/staging/mt7621-dts/mt7621.dtsi | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos