* [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable
@ 2022-03-21 12:36 Jakob Koschel
2022-03-21 12:44 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jakob Koschel @ 2022-03-21 12:36 UTC (permalink / raw)
To: Vaibhav Agarwal
Cc: Jakob Koschel, linux-kernel, greybus-dev, linux-staging,
Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Mike Rapoport, Brian Johannesmeyer, Cristiano Giuffrida,
Bos, H.J.
If the list does not exit early then data == NULL and 'module' does not
point to a valid list element.
Using 'module' in such a case is not valid and was therefore removed.
Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index b589cf6b1d03..e19b91e7a72e 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
break;
}
if (!data) {
- dev_err(dai->dev, "%s:%s DATA connection missing\n",
- dai->name, module->name);
+ dev_err(dai->dev, "%s DATA connection missing\n",
+ dai->name);
mutex_unlock(&codec->lock);
return -ENODEV;
}
base-commit: f443e374ae131c168a065ea1748feac6b2e76613
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable
2022-03-21 12:36 [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable Jakob Koschel
@ 2022-03-21 12:44 ` Dan Carpenter
2022-03-21 17:56 ` Mark Greer
2022-03-21 18:38 ` Vaibhav Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-03-21 12:44 UTC (permalink / raw)
To: Jakob Koschel
Cc: Vaibhav Agarwal, linux-kernel, greybus-dev, linux-staging,
Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Mike Rapoport, Brian Johannesmeyer, Cristiano Giuffrida,
Bos, H.J.
On Mon, Mar 21, 2022 at 01:36:26PM +0100, Jakob Koschel wrote:
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.
>
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable
2022-03-21 12:36 [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable Jakob Koschel
2022-03-21 12:44 ` Dan Carpenter
@ 2022-03-21 17:56 ` Mark Greer
2022-03-21 18:38 ` Vaibhav Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Mark Greer @ 2022-03-21 17:56 UTC (permalink / raw)
To: Jakob Koschel
Cc: Vaibhav Agarwal, linux-kernel, greybus-dev, linux-staging,
Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Mike Rapoport, Brian Johannesmeyer, Cristiano Giuffrida,
Bos, H.J.
On Mon, Mar 21, 2022 at 01:36:26PM +0100, Jakob Koschel wrote:
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.
>
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..e19b91e7a72e 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
> break;
> }
> if (!data) {
> - dev_err(dai->dev, "%s:%s DATA connection missing\n",
> - dai->name, module->name);
> + dev_err(dai->dev, "%s DATA connection missing\n",
> + dai->name);
> mutex_unlock(&codec->lock);
> return -ENODEV;
> }
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable
2022-03-21 12:36 [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable Jakob Koschel
2022-03-21 12:44 ` Dan Carpenter
2022-03-21 17:56 ` Mark Greer
@ 2022-03-21 18:38 ` Vaibhav Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Vaibhav Agarwal @ 2022-03-21 18:38 UTC (permalink / raw)
To: Jakob Koschel
Cc: open list, moderated list:GREYBUS SUBSYSTEM, linux-staging,
Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Mike Rapoport, Brian Johannesmeyer, Cristiano Giuffrida,
Bos, H.J.
On Mon, Mar 21, 2022 at 6:07 PM Jakob Koschel <jakobkoschel@gmail.com> wrote:
>
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.
>
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..e19b91e7a72e 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
> break;
> }
> if (!data) {
> - dev_err(dai->dev, "%s:%s DATA connection missing\n",
> - dai->name, module->name);
> + dev_err(dai->dev, "%s DATA connection missing\n",
> + dai->name);
> mutex_unlock(&codec->lock);
> return -ENODEV;
> }
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-21 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-21 12:36 [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable Jakob Koschel
2022-03-21 12:44 ` Dan Carpenter
2022-03-21 17:56 ` Mark Greer
2022-03-21 18:38 ` Vaibhav Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox