From: Alison Schofield <alison.schofield@intel.com>
To: Rebecca Mckeever <remckee0@gmail.com>
Cc: outreachy@lists.linux.dev,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: r8188eu: remove extra 'the'
Date: Wed, 6 Apr 2022 15:32:22 -0700 [thread overview]
Message-ID: <20220406223222.GB1210425@alison-desk> (raw)
In-Reply-To: <e259a035b79c814f871b490aa277bf0dfe23fe11.1649233201.git.remckee0@gmail.com>
On Wed, Apr 06, 2022 at 03:30:58AM -0500, Rebecca Mckeever wrote:
> Remove repeated 'the' in comment to be grammatically correct and
> conform to Linux kernel coding style.
>
> Found with checkpatch:
> WARNING: Possible repeated word: 'the'
>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 9f5ece52bd39..cd20811ae152 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -519,7 +519,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork)
>
> psecnetwork->IELength = 0;
> /* Added by Albert 2009/02/18 */
I don't know if this type of thing "Added by Albert" is sprinkled through
the file, but it seems they can be removed. Git will keep history of
this file from here on. (And in case anyone asks what happened to
Albert's notations, they can find that in the git history too ;))
> - /* If the the driver wants to use the bssid to create the connection. */
> + /* If the driver wants to use the bssid to create the connection. */
> /* If not, we have to copy the connecting AP's MAC address to it so that */
> /* the driver just has the bssid information for PMKIDList searching. */
>
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2022-04-06 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 8:30 [PATCH 0/4] staging: r8188eu: cleanup of style and typos Rebecca Mckeever
2022-04-06 8:30 ` [PATCH 1/4] staging: r8188eu: format comments in drivers/net style Rebecca Mckeever
2022-04-06 8:30 ` [PATCH 2/4] staging: r8188eu: remove extra 'the' Rebecca Mckeever
2022-04-06 22:32 ` Alison Schofield [this message]
2022-04-06 8:30 ` [PATCH 3/4] staging: r8188eu: correct misspelling in comment 'tppe' -> 'type' Rebecca Mckeever
2022-04-06 18:37 ` Dave Jiang
2022-04-06 8:31 ` [PATCH 4/4] staging: r8188eu: use sizeof(*pvar) for allocating structs Rebecca Mckeever
2022-04-14 23:43 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406223222.GB1210425@alison-desk \
--to=alison.schofield@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=remckee0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox