From: Dave Jiang <dave.jiang@intel.com>
To: Rebecca Mckeever <remckee0@gmail.com>, outreachy@lists.linux.dev
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 3/4] staging: r8188eu: correct misspelling in comment 'tppe' -> 'type'
Date: Wed, 6 Apr 2022 11:37:40 -0700 [thread overview]
Message-ID: <b19466ad-afae-7c70-cd28-73e3959c48f4@intel.com> (raw)
In-Reply-To: <edaab7d38893e4f1cbb3c281b617c74fa91f0fe7.1649233201.git.remckee0@gmail.com>
On 4/6/2022 1:30 AM, Rebecca Mckeever wrote:
> Correct spelling typo.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index cd20811ae152..f4a277e6b654 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -1162,7 +1162,7 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
> }
>
> pdrvextra_cmd_parm->ec_id = P2P_PROTO_WK_CID;
> - pdrvextra_cmd_parm->type_size = intCmdType; /* As the command tppe. */
> + pdrvextra_cmd_parm->type_size = intCmdType; /* As the command type. */
Nothing to do with this patch. Just saw intCmdType. Suggest another
patch to fix this mixed case function parameter. Maybe cmd_type instead?
> pdrvextra_cmd_parm->pbuf = NULL; /* Must be NULL here */
>
> init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra));
next prev parent reply other threads:[~2022-04-06 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 8:30 [PATCH 0/4] staging: r8188eu: cleanup of style and typos Rebecca Mckeever
2022-04-06 8:30 ` [PATCH 1/4] staging: r8188eu: format comments in drivers/net style Rebecca Mckeever
2022-04-06 8:30 ` [PATCH 2/4] staging: r8188eu: remove extra 'the' Rebecca Mckeever
2022-04-06 22:32 ` Alison Schofield
2022-04-06 8:30 ` [PATCH 3/4] staging: r8188eu: correct misspelling in comment 'tppe' -> 'type' Rebecca Mckeever
2022-04-06 18:37 ` Dave Jiang [this message]
2022-04-06 8:31 ` [PATCH 4/4] staging: r8188eu: use sizeof(*pvar) for allocating structs Rebecca Mckeever
2022-04-14 23:43 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b19466ad-afae-7c70-cd28-73e3959c48f4@intel.com \
--to=dave.jiang@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=remckee0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox