[PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

[PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

[aliya-rahmani]

From: Aliya Rahmani <aliyarahmani786@gmail.com>

Removed indentation to fix the checkpatch error that lines should not
end with a '('.

Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>

---
 drivers/staging/vt6655/rxtx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 53506e242a96..dce9d87d2363 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -569,8 +569,7 @@ s_uFillDataHead(
 
 static
 void
-s_vFillRTSHead(
-	struct vnt_private *pDevice,
+s_vFillRTSHead(struct vnt_private *pDevice,
 	unsigned char byPktType,
 	void *pvRTS,
 	unsigned int cbFrameLength,
-- 
2.25.1

Re: [PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

[Dan Carpenter]

On Wed, Apr 13, 2022 at 01:05:45PM +0530, aliya-rahmani wrote:
> From: Aliya Rahmani <aliyarahmani786@gmail.com>
> 
> Removed indentation to fix the checkpatch error that lines should not
> end with a '('.
> 
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> 
> ---
>  drivers/staging/vt6655/rxtx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 53506e242a96..dce9d87d2363 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -569,8 +569,7 @@ s_uFillDataHead(
>  
>  static
>  void
> -s_vFillRTSHead(
> -	struct vnt_private *pDevice,
> +s_vFillRTSHead(struct vnt_private *pDevice,
>  	unsigned char byPktType,

Indent these lines as well and move the ) forward.

s_vFillRTSHead(struct vnt_private *pDevice,
	       unsigned char byPktType,
	       ...
	       unsigned char byFBOption)
{

regards,
dan carpenter

Re: [PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

[Julia Lawall]

On Wed, 13 Apr 2022, aliya-rahmani wrote:

> From: Aliya Rahmani <aliyarahmani786@gmail.com>
>
> Removed indentation to fix the checkpatch error that lines should not
> end with a '('.

The log message should be in the imperative, so it would be "Remove", not
"Removed".

Maybe it would be nice to keep the parameters aligned, thus indent the
others more?

In another patch you could improve the variable names and the function
name.  I'm not sure why static and void have to be on separate lines
either.

julia


>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
>
> ---
>  drivers/staging/vt6655/rxtx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 53506e242a96..dce9d87d2363 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -569,8 +569,7 @@ s_uFillDataHead(
>
>  static
>  void
> -s_vFillRTSHead(
> -	struct vnt_private *pDevice,
> +s_vFillRTSHead(struct vnt_private *pDevice,
>  	unsigned char byPktType,
>  	void *pvRTS,
>  	unsigned int cbFrameLength,
> --
> 2.25.1
>
>
>