* [PATCH] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
@ 2022-04-14 10:34 Haowen Bai
2022-04-14 11:34 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-04-14 10:34 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Haowen Bai, linux-staging, linux-kernel
function rtllib_rx_assoc_resp () unsigned errcode receive auth_parse()'s
errcode -ENOMEM.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 4b6c2295a3cf..57f70cc8cb81 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1764,7 +1764,7 @@ static void rtllib_softmac_check_all_nets(struct rtllib_device *ieee)
spin_unlock_irqrestore(&ieee->lock, flags);
}
-static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
+static inline s16 auth_parse(struct net_device *dev, struct sk_buff *skb,
u8 **challenge, int *chlen)
{
struct rtllib_authentication *a;
@@ -2278,7 +2278,7 @@ rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
{
- u16 errcode;
+ s16 errcode;
u8 *challenge;
int chlen = 0;
bool bSupportNmode = true, bHalfSupportNmode = false;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
2022-04-14 10:34 [PATCH] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Haowen Bai
@ 2022-04-14 11:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-04-14 11:34 UTC (permalink / raw)
To: Haowen Bai; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Thu, Apr 14, 2022 at 06:34:50PM +0800, Haowen Bai wrote:
> function rtllib_rx_assoc_resp () unsigned errcode receive auth_parse()'s
> errcode -ENOMEM.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
Same thing. Make it return normal error codes.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-14 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-14 10:34 [PATCH] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Haowen Bai
2022-04-14 11:34 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox