From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 03/12] staging: r8188eu: viq_cnt is write-only
Date: Mon, 9 Jan 2023 22:28:43 +0100 [thread overview]
Message-ID: <20230109212852.75612-4-martin@kaiser.cx> (raw)
In-Reply-To: <20230109212852.75612-1-martin@kaiser.cx>
viq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove viq_cnt and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_xmit.c | 1 -
drivers/staging/r8188eu/include/rtw_xmit.h | 1 -
drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 4 ----
3 files changed, 6 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 875675656d11..1319a7fce8b3 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -195,7 +195,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
pxmitpriv->txirp_cnt = 1;
/* per AC pending irp */
- pxmitpriv->viq_cnt = 0;
pxmitpriv->voq_cnt = 0;
pxmitpriv->ack_tx = false;
diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h
index 3d56c3afaf7d..71a7fb33b0d0 100644
--- a/drivers/staging/r8188eu/include/rtw_xmit.h
+++ b/drivers/staging/r8188eu/include/rtw_xmit.h
@@ -282,7 +282,6 @@ struct xmit_priv {
u8 txirp_cnt;/* */
struct tasklet_struct xmit_tasklet;
/* per AC pending irp */
- int viq_cnt;
int voq_cnt;
struct __queue free_xmitbuf_queue;
struct __queue pending_xmitbuf_queue;
diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
index 5ae09edf9174..7929b7d5e89e 100644
--- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
@@ -45,9 +45,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
case VO_QUEUE_INX:
pxmitpriv->voq_cnt--;
break;
- case VI_QUEUE_INX:
- pxmitpriv->viq_cnt--;
- break;
case HIGH_QUEUE_INX:
rtw_chk_hi_queue_cmd(padapter);
break;
@@ -113,7 +110,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem)
pxmitbuf->flags = VO_QUEUE_INX;
break;
case VI_QUEUE_INX:
- pxmitpriv->viq_cnt++;
pxmitbuf->flags = VI_QUEUE_INX;
break;
case BE_QUEUE_INX:
--
2.30.2
next prev parent reply other threads:[~2023-01-09 21:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 18:57 [PATCH 00/13] staging: r8188eu: some more xmit cleanups Martin Kaiser
2023-01-08 18:57 ` [PATCH 01/13] staging: r8188eu: beq_cnt is write-only Martin Kaiser
2023-01-08 18:57 ` [PATCH 02/13] staging: r8188eu: bkq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 03/13] staging: r8188eu: viq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 04/13] staging: r8188eu: voq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 05/13] staging: r8188eu: replace switch with if Martin Kaiser
2023-01-08 18:57 ` [PATCH 06/13] staging: r8188eu: make rtl8188eu_inirp_init a void function Martin Kaiser
2023-01-08 19:57 ` Pavel Skripkin
2023-01-09 21:24 ` Martin Kaiser
2023-01-08 18:57 ` [PATCH 07/13] staging: r8188eu: dir_dev is unused Martin Kaiser
2023-01-08 18:57 ` [PATCH 08/13] staging: r8188eu: remove unused hal_xmit_handler define Martin Kaiser
2023-01-08 18:57 ` [PATCH 09/13] staging: r8188eu: txirp_cnt is write-only Martin Kaiser
2023-01-08 18:57 ` [PATCH 10/13] staging: r8188eu: remove unused QSLT defines Martin Kaiser
2023-01-08 18:57 ` [PATCH 11/13] staging: r8188eu: xmit_priv's vcs_type is not used Martin Kaiser
2023-01-08 18:57 ` [PATCH 12/13] staging: r8188eu: xmit_priv's vcs " Martin Kaiser
2023-01-08 18:57 ` [PATCH 13/13] staging: r8188eu: xmit_priv's vcs_setting " Martin Kaiser
2023-01-08 20:44 ` [PATCH 00/13] staging: r8188eu: some more xmit cleanups Philipp Hortmann
2023-01-09 21:28 ` [PATCH v2 00/12] " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 01/12] staging: r8188eu: beq_cnt is write-only Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 02/12] staging: r8188eu: bkq_cnt " Martin Kaiser
2023-01-09 21:28 ` Martin Kaiser [this message]
2023-01-09 21:28 ` [PATCH v2 04/12] staging: r8188eu: voq_cnt " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 05/12] staging: r8188eu: replace switch with if Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 06/12] staging: r8188eu: dir_dev is unused Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 07/12] staging: r8188eu: remove unused hal_xmit_handler define Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 08/12] staging: r8188eu: txirp_cnt is write-only Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 09/12] staging: r8188eu: remove unused QSLT defines Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 10/12] staging: r8188eu: xmit_priv's vcs_type is not used Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 11/12] staging: r8188eu: xmit_priv's vcs " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 12/12] staging: r8188eu: xmit_priv's vcs_setting " Martin Kaiser
2023-01-09 22:34 ` [PATCH v2 00/12] staging: r8188eu: some more xmit cleanups Philipp Hortmann
2023-01-10 18:13 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109212852.75612-4-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox