From: Pavel Skripkin <paskripkin@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/13] staging: r8188eu: make rtl8188eu_inirp_init a void function
Date: Sun, 8 Jan 2023 22:57:39 +0300 [thread overview]
Message-ID: <ab4727b9-69c1-ba8d-38d8-6a3c721ba2aa@gmail.com> (raw)
In-Reply-To: <20230108185738.597105-7-martin@kaiser.cx>
Hi Martin,
Martin Kaiser <martin@kaiser.cx> says:
> rtl8188eu_inirp_init's return value is not checked by its caller. Make
> rtl8188eu_inirp_init a void function.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 14 +++-----------
> drivers/staging/r8188eu/include/hal_intf.h | 2 +-
> 2 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index d28b4dc2a767..afa24a59fbb3 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -851,29 +851,21 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter)
> return _SUCCESS;
> }
>
> -unsigned int rtl8188eu_inirp_init(struct adapter *Adapter)
> +void rtl8188eu_inirp_init(struct adapter *Adapter)
Hm, shouldn't we actually check return value on caller side?
This thing is called from netdev_open and issues urbs to read data from
the device. So let's imagine that we fail on 1st iteration (for some
reason): netdev_open() says all is OK, but driver does not communicate
with the device.
Maybe these urbs are not that important, tho..
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2023-01-08 19:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 18:57 [PATCH 00/13] staging: r8188eu: some more xmit cleanups Martin Kaiser
2023-01-08 18:57 ` [PATCH 01/13] staging: r8188eu: beq_cnt is write-only Martin Kaiser
2023-01-08 18:57 ` [PATCH 02/13] staging: r8188eu: bkq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 03/13] staging: r8188eu: viq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 04/13] staging: r8188eu: voq_cnt " Martin Kaiser
2023-01-08 18:57 ` [PATCH 05/13] staging: r8188eu: replace switch with if Martin Kaiser
2023-01-08 18:57 ` [PATCH 06/13] staging: r8188eu: make rtl8188eu_inirp_init a void function Martin Kaiser
2023-01-08 19:57 ` Pavel Skripkin [this message]
2023-01-09 21:24 ` Martin Kaiser
2023-01-08 18:57 ` [PATCH 07/13] staging: r8188eu: dir_dev is unused Martin Kaiser
2023-01-08 18:57 ` [PATCH 08/13] staging: r8188eu: remove unused hal_xmit_handler define Martin Kaiser
2023-01-08 18:57 ` [PATCH 09/13] staging: r8188eu: txirp_cnt is write-only Martin Kaiser
2023-01-08 18:57 ` [PATCH 10/13] staging: r8188eu: remove unused QSLT defines Martin Kaiser
2023-01-08 18:57 ` [PATCH 11/13] staging: r8188eu: xmit_priv's vcs_type is not used Martin Kaiser
2023-01-08 18:57 ` [PATCH 12/13] staging: r8188eu: xmit_priv's vcs " Martin Kaiser
2023-01-08 18:57 ` [PATCH 13/13] staging: r8188eu: xmit_priv's vcs_setting " Martin Kaiser
2023-01-08 20:44 ` [PATCH 00/13] staging: r8188eu: some more xmit cleanups Philipp Hortmann
2023-01-09 21:28 ` [PATCH v2 00/12] " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 01/12] staging: r8188eu: beq_cnt is write-only Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 02/12] staging: r8188eu: bkq_cnt " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 03/12] staging: r8188eu: viq_cnt " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 04/12] staging: r8188eu: voq_cnt " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 05/12] staging: r8188eu: replace switch with if Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 06/12] staging: r8188eu: dir_dev is unused Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 07/12] staging: r8188eu: remove unused hal_xmit_handler define Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 08/12] staging: r8188eu: txirp_cnt is write-only Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 09/12] staging: r8188eu: remove unused QSLT defines Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 10/12] staging: r8188eu: xmit_priv's vcs_type is not used Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 11/12] staging: r8188eu: xmit_priv's vcs " Martin Kaiser
2023-01-09 21:28 ` [PATCH v2 12/12] staging: r8188eu: xmit_priv's vcs_setting " Martin Kaiser
2023-01-09 22:34 ` [PATCH v2 00/12] staging: r8188eu: some more xmit cleanups Philipp Hortmann
2023-01-10 18:13 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4727b9-69c1-ba8d-38d8-6a3c721ba2aa@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox