Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8192e: Use BIT() instead of << for bit field MSR_LINK_MASK
@ 2023-02-08 18:56 Philipp Hortmann
  0 siblings, 0 replies; only message in thread
From: Philipp Hortmann @ 2023-02-08 18:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman, linux-staging, linux-kernel

Use commonly used BIT() macro to define MSR_LINK_MASK. Equation is
not accepted by checkpatch because of missing spaces. Therefore line
needs to change anyhow.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
V1->V2: Changed patch, title and description
        Calculate MSR_LINK_MASK ((1<<0)|(1<<1)) = 3 is not wanted for
        bit fields
        Old patch name: Calculate definition of MSR_LINK_MASK
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h
index 8b8a870fcbbd..99640c4779f7 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h
@@ -170,7 +170,7 @@ enum _RTL8192PCI_HW {
 #define	BW_OPMODE_20MHZ			BIT2
 	IC_VERRSION		= 0x301,
 	MSR			= 0x303,
-#define MSR_LINK_MASK      ((1<<0)|(1<<1))
+#define MSR_LINK_MASK		(BIT(1) | BIT(0))
 #define MSR_LINK_MANAGED   2
 #define MSR_LINK_ADHOC     1
 #define MSR_LINK_MASTER    3
-- 
2.39.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-08 18:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 18:56 [PATCH v2] staging: rtl8192e: Use BIT() instead of << for bit field MSR_LINK_MASK Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox