* [PATCH] staging: wlan-ng: add comment to spinlock_t
@ 2023-04-02 15:32 Dalvin-Ehinoma Noah Aiguobas
2023-04-02 15:36 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Dalvin-Ehinoma Noah Aiguobas @ 2023-04-02 15:32 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Fix checkpatch.pl warning: spinlock_t definition without comment in
drivers/staging/wlan-ng/hfa384x.h
Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <pharcodra@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index e33dd1b9c40e..fc6d67cec5b1 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1000,7 +1000,7 @@ struct hfa384x_usbctlx {
};
struct hfa384x_usbctlxq {
- spinlock_t lock;
+ spinlock_t lock; /* disable interrupts while working in hfa384 or hfa384x_usbctlx */
struct list_head pending;
struct list_head active;
struct list_head completing;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: wlan-ng: add comment to spinlock_t
2023-04-02 15:32 [PATCH] staging: wlan-ng: add comment to spinlock_t Dalvin-Ehinoma Noah Aiguobas
@ 2023-04-02 15:36 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-04-02 15:36 UTC (permalink / raw)
To: Dalvin-Ehinoma Noah Aiguobas; +Cc: linux-staging, linux-kernel
On Sun, Apr 02, 2023 at 05:32:44PM +0200, Dalvin-Ehinoma Noah Aiguobas wrote:
> Fix checkpatch.pl warning: spinlock_t definition without comment in
> drivers/staging/wlan-ng/hfa384x.h
>
> Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <pharcodra@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index e33dd1b9c40e..fc6d67cec5b1 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1000,7 +1000,7 @@ struct hfa384x_usbctlx {
> };
>
> struct hfa384x_usbctlxq {
> - spinlock_t lock;
> + spinlock_t lock; /* disable interrupts while working in hfa384 or hfa384x_usbctlx */
Disable interrupts? Are you sure that is what this lock is doing?
And what exactly does "while working in..." mean?
Why not just write real kernel doc for all of the fields in this
structure?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-02 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-02 15:32 [PATCH] staging: wlan-ng: add comment to spinlock_t Dalvin-Ehinoma Noah Aiguobas
2023-04-02 15:36 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox