From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: loopback: fix up checkpath macro do while error.
Date: Sun, 2 Apr 2023 15:16:09 +0200 [thread overview]
Message-ID: <2023040252-racoon-daintily-3589@gregkh> (raw)
In-Reply-To: <20230402122550.70682-1-angelalbertoc.r@gmail.com>
On Sun, Apr 02, 2023 at 02:25:51PM +0200, Angel Alberto Carretero wrote:
> Wrap macro in a do-while statement.
>
> Signed-off-by: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index d7b39f3bb652..371809770ed0 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -162,9 +162,11 @@ static ssize_t name##_avg_show(struct device *dev, \
> static DEVICE_ATTR_RO(name##_avg)
>
> #define gb_loopback_stats_attrs(field) \
> - gb_loopback_ro_stats_attr(field, min, u); \
> - gb_loopback_ro_stats_attr(field, max, u); \
> - gb_loopback_ro_avg_attr(field)
> + do { \
> + gb_loopback_ro_stats_attr(field, min, u); \
> + gb_loopback_ro_stats_attr(field, max, u); \
> + gb_loopback_ro_avg_attr(field); \
> + } while (0)
>
> #define gb_loopback_attr(field, type) \
> static ssize_t field##_show(struct device *dev, \
> --
> 2.40.0
>
>
Any specific reason why you did not test build your change before
submitting it?
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-02 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 12:25 [PATCH] staging: greybus: loopback: fix up checkpath macro do while error Angel Alberto Carretero
2023-04-02 13:16 ` Greg Kroah-Hartman [this message]
2023-04-02 18:22 ` Ángel Alberto Carretero
2023-04-03 6:23 ` Dan Carpenter
2023-04-03 7:21 ` Greg Kroah-Hartman
2023-04-03 13:50 ` Ángel Alberto Carretero
2023-04-02 13:58 ` kernel test robot
2023-04-02 14:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040252-racoon-daintily-3589@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=angelalbertoc.r@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox