* [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
@ 2023-05-19 10:01 Deepanshu Kartikey
2023-05-19 10:06 ` Greg KH
2023-05-19 10:09 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Deepanshu Kartikey @ 2023-05-19 10:01 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, Deepanshu Kartikey
Moved else statement to same line with else if,
this warning was given by checkpatch.pl
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
@ 2023-05-19 10:05 Deepanshu Kartikey
0 siblings, 0 replies; 4+ messages in thread
From: Deepanshu Kartikey @ 2023-05-19 10:05 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, Deepanshu Kartikey
Moved else statement to same line with else if,
this warning was given by checkpatch.pl
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
2023-05-19 10:01 [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
@ 2023-05-19 10:06 ` Greg KH
2023-05-19 10:09 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2023-05-19 10:06 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: linux-kernel, linux-staging
On Fri, May 19, 2023 at 03:31:19PM +0530, Deepanshu Kartikey wrote:
> Moved else statement to same line with else if,
> this warning was given by checkpatch.pl
>
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
>
> ...
> Changes in V2:
> - Moved else to the same line with else if
> - Moved comment on else statement to inside of it
This needs to go below:
> ---
That line, so that these comments do not end up in the changelog.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
2023-05-19 10:01 [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
2023-05-19 10:06 ` Greg KH
@ 2023-05-19 10:09 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-05-19 10:09 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: gregkh, linux-kernel, linux-staging
On Fri, May 19, 2023 at 03:31:19PM +0530, Deepanshu Kartikey wrote:
> Moved else statement to same line with else if,
> this warning was given by checkpatch.pl
>
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
>
> ...
> Changes in V2:
> - Moved else to the same line with else if
> - Moved comment on else statement to inside of it
> ---
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Please read my blog about how to resend a patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-19 10:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-19 10:01 [PATCH] [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
2023-05-19 10:06 ` Greg KH
2023-05-19 10:09 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 10:05 Deepanshu Kartikey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox