From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Axel Haslam" <ahaslam@baylibre.com>,
"Philip Molloy" <pmolloy@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] staging: iio: resolver: ad2s1210: clear faults after soft reset
Date: Thu, 12 Oct 2023 08:59:26 +0100 [thread overview]
Message-ID: <20231012085926.2104251a@jic23-huawei> (raw)
In-Reply-To: <20231010-ad2s1210-mainline-v5-2-35a0f6ffa04a@baylibre.com>
On Tue, 10 Oct 2023 16:12:34 -0500
David Lechner <dlechner@baylibre.com> wrote:
> When a software reset is performed on the AD2S1210 to make the selected
> excitation frequency take effect, it always triggers faults on the
> input signals because the output signal is interrupted momentarily.
> So we need to clear the faults after the software reset to avoid
> triggering fault events the next time a sample is read.
>
> The datasheet specifies a time t[track] in Table 27 that specifies the
> settle time in milliseconds after a reset depending on the selected
> resolution. This is used in the driver to add an appropriate delay.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied
next prev parent reply other threads:[~2023-10-12 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 21:12 [PATCH v5 0/4] iio: resolver: move ad2s1210 out of staging David Lechner
2023-10-10 21:12 ` [PATCH v5 1/4] staging: iio: resolver: ad2s1210: refactor sample toggle David Lechner
2023-10-12 7:58 ` Jonathan Cameron
2023-10-10 21:12 ` [PATCH v5 2/4] staging: iio: resolver: ad2s1210: clear faults after soft reset David Lechner
2023-10-12 7:59 ` Jonathan Cameron [this message]
2023-10-10 21:12 ` [PATCH v5 3/4] staging: iio: resolver: ad2s1210: simplify code with guard(mutex) David Lechner
2023-10-12 8:01 ` Jonathan Cameron
2023-10-10 21:12 ` [PATCH v5 4/4] iio: resolver: ad2s1210: move out of staging David Lechner
2023-10-12 8:25 ` Jonathan Cameron
2023-10-12 16:23 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012085926.2104251a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ahaslam@baylibre.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=pmolloy@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox