* [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis
@ 2023-12-26 11:04 phanirajkiran
2024-01-04 13:32 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: phanirajkiran @ 2023-12-26 11:04 UTC (permalink / raw)
Cc: phanirajkiran.a, Greg Kroah-Hartman, Prathu Baronia, Rob Herring,
Uwe Kleine-König, Yangtao Li, Khadija Kamran, linux-staging,
linux-kernel
This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis
Signed-off-by: phanirajkiran <phanirajkiran.a@gmail.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 727b956aa231..ab758a527261 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
- read_timeout);
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ read_timeout);
if (ret <= 0) {
if (ret == 0) {
@@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
*/
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible_timeout(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
- >= words_to_write,
- write_timeout);
+ ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+ >= words_to_write,
+ write_timeout);
if (ret <= 0) {
if (ret == 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis
2023-12-26 11:04 [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis phanirajkiran
@ 2024-01-04 13:32 ` Greg Kroah-Hartman
[not found] ` <CAJEOW9YiuBSLUrP0BkRGQRmJWOKpB4Y=DhTGUnDDumhuzmcH1A@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2024-01-04 13:32 UTC (permalink / raw)
To: phanirajkiran
Cc: Prathu Baronia, Rob Herring, Uwe Kleine-König, Yangtao Li,
Khadija Kamran, linux-staging, linux-kernel
On Tue, Dec 26, 2023 at 04:34:58PM +0530, phanirajkiran wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: phanirajkiran <phanirajkiran.a@gmail.com>
To be sure, is this the name you use for identification? Just one word?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis
@ 2024-04-28 12:04 pipishuo
2024-04-28 13:59 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: pipishuo @ 2024-04-28 12:04 UTC (permalink / raw)
To: linux-staging, linux-kernel, 1289151713
This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis
Signed-off-by: pipishuo <1289151713@qq.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index c51818c56dd2..04f0e5b45a8b 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -376,7 +376,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
read_timeout);
if (ret <= 0) {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis
2024-04-28 12:04 pipishuo
@ 2024-04-28 13:59 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-04-28 13:59 UTC (permalink / raw)
To: pipishuo; +Cc: linux-staging, linux-kernel
On Sun, Apr 28, 2024 at 08:04:34PM +0800, pipishuo wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: pipishuo <1289151713@qq.com>
This is your legal name that you use to sign legal documents? Just one
word, all lower case?
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c51818c56dd2..04f0e5b45a8b 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -376,7 +376,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> read_timeout);
Checkpatch is just a tool. It's supposed to make the code more
readable. Sometimes it makes mistakes and makes the code worse.
If it tells you to do something crazy then just ignore it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-28 13:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-26 11:04 [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis phanirajkiran
2024-01-04 13:32 ` Greg Kroah-Hartman
[not found] ` <CAJEOW9YiuBSLUrP0BkRGQRmJWOKpB4Y=DhTGUnDDumhuzmcH1A@mail.gmail.com>
2024-01-04 14:22 ` Greg Kroah-Hartman
2024-01-04 15:56 ` Phanirajkiran
-- strict thread matches above, loose matches on Subject: below --
2024-04-28 12:04 pipishuo
2024-04-28 13:59 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox