* [PATCH] staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch
@ 2024-02-21 9:54 sawara04.o
2024-02-21 10:18 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: sawara04.o @ 2024-02-21 9:54 UTC (permalink / raw)
To: gregkh, sawara04.o; +Cc: dri-devel, linux-fbdev, linux-staging
From: Kyoji Ogasawara <sawara04.o@gmail.com>
Since whitespace is prohibited before that close parenthesis ')' in a
conditional statements, remove it and fix checkpatch.pl error "space prohibited before that
close parenthesis ')'".
Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 3d422bc11641..02a16671f2a1 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out: \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch
2024-02-21 9:54 [PATCH] staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch sawara04.o
@ 2024-02-21 10:18 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-02-21 10:18 UTC (permalink / raw)
To: sawara04.o; +Cc: gregkh, dri-devel, linux-fbdev, linux-staging
On Wed, Feb 21, 2024 at 06:54:04PM +0900, sawara04.o@gmail.com wrote:
> From: Kyoji Ogasawara <sawara04.o@gmail.com>
>
> Since whitespace is prohibited before that close parenthesis ')' in a
> conditional statements, remove it and fix checkpatch.pl error "space prohibited before that
> close parenthesis ')'".
>
> Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
This breaks the build. You could do a search for it.
https://lore.kernel.org/all/?q=define_fbtft_write_reg
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-21 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 9:54 [PATCH] staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch sawara04.o
2024-02-21 10:18 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox