* [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection
@ 2024-03-05 22:45 Dorine Tipo
2024-03-07 7:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Dorine Tipo @ 2024-03-05 22:45 UTC (permalink / raw)
To: gregkh, linux-staging, outreachy; +Cc: Dorine Tipo
Rename variable sii164EnableHotPlugDetection to
sii164_enable_hot_plug_detection to silence checkpatch warning Avoid
CamelCase
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index c12df1f9fb00..1ce44c50617a 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.reset_chip = sii164_reset_chip,
.get_chip_string = sii164_get_chip_string,
.set_power = sii164_set_power,
- .enable_hot_plug_detection = sii164EnableHotPlugDetection,
+ .enable_hot_plug_detection = sii164_enable_hot_plug_detection,
.is_connected = sii164IsConnected,
.check_interrupt = sii164CheckInterrupt,
.clear_interrupt = sii164ClearInterrupt,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection
2024-03-05 22:45 [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection Dorine Tipo
@ 2024-03-07 7:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-03-07 7:22 UTC (permalink / raw)
To: Dorine Tipo; +Cc: linux-staging, outreachy
On Tue, Mar 05, 2024 at 10:45:18PM +0000, Dorine Tipo wrote:
> Rename variable sii164EnableHotPlugDetection to
> sii164_enable_hot_plug_detection to silence checkpatch warning Avoid
> CamelCase
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index c12df1f9fb00..1ce44c50617a 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> .reset_chip = sii164_reset_chip,
> .get_chip_string = sii164_get_chip_string,
> .set_power = sii164_set_power,
> - .enable_hot_plug_detection = sii164EnableHotPlugDetection,
> + .enable_hot_plug_detection = sii164_enable_hot_plug_detection,
> .is_connected = sii164IsConnected,
> .check_interrupt = sii164CheckInterrupt,
> .clear_interrupt = sii164ClearInterrupt,
> --
> 2.25.1
>
>
Hi,
You sent 5 patches, all look to be broken and not tested. Please fix
them up and send them as a patch series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-07 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-05 22:45 [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection Dorine Tipo
2024-03-07 7:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox