* [PATCH] Staging:sm750fb: Rename variable sii164GetChipString
@ 2024-03-05 22:32 Dorine Tipo
2024-03-07 7:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dorine Tipo @ 2024-03-05 22:32 UTC (permalink / raw)
To: gregkh, linux-staging, outreachy; +Cc: Dorine Tipo
Rename variable sii164GetChipString to sii164Get_chip_string to fix
checkpatch warning Avoid CamelCase
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 6dee95e60a6e..e568c210e2bd 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -19,7 +19,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
.reset_chip = sii164_reset_chip,
- .get_chip_string = sii164GetChipString,
+ .get_chip_string = sii164_get_chip_string,
.set_power = sii164SetPower,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
.is_connected = sii164IsConnected,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging:sm750fb: Rename variable sii164GetChipString
2024-03-05 22:32 [PATCH] Staging:sm750fb: Rename variable sii164GetChipString Dorine Tipo
@ 2024-03-07 7:21 ` Greg KH
2024-03-07 7:22 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2024-03-07 7:21 UTC (permalink / raw)
To: Dorine Tipo; +Cc: linux-staging, outreachy
On Tue, Mar 05, 2024 at 10:32:48PM +0000, Dorine Tipo wrote:
> Rename variable sii164GetChipString to sii164Get_chip_string to fix
> checkpatch warning Avoid CamelCase
That's not what this patch does :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging:sm750fb: Rename variable sii164GetChipString
2024-03-07 7:21 ` Greg KH
@ 2024-03-07 7:22 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2024-03-07 7:22 UTC (permalink / raw)
To: Dorine Tipo; +Cc: linux-staging, outreachy
On Thu, Mar 07, 2024 at 07:21:33AM +0000, Greg KH wrote:
> On Tue, Mar 05, 2024 at 10:32:48PM +0000, Dorine Tipo wrote:
> > Rename variable sii164GetChipString to sii164Get_chip_string to fix
> > checkpatch warning Avoid CamelCase
>
> That's not what this patch does :(
>
Also, did you test-build it? Your change looks to break the build,
sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-07 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-05 22:32 [PATCH] Staging:sm750fb: Rename variable sii164GetChipString Dorine Tipo
2024-03-07 7:21 ` Greg KH
2024-03-07 7:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox