Linux kernel staging patches
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 22/24] Remove variable IsAmsdu from rtllib_xmit_inter()
Date: Sun,  9 Jun 2024 22:44:47 -0700	[thread overview]
Message-ID: <20240610054449.71316-23-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240610054449.71316-1-tdavies@darkphysics.net>

Remove boolean variable, IsAmsdu, and code which does not
execute because it is never set to true.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_tx.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index deae90640e90..eb1668458e30 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -539,7 +539,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 	struct lib80211_crypt_data *crypt = NULL;
 	struct cb_desc *tcb_desc;
 	u8 is_multicast = false;
-	u8 IsAmsdu = false;
 	bool	bdhcp = false;
 
 	spin_lock_irqsave(&ieee->lock, flags);
@@ -648,11 +647,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 		ether_addr_copy(header.addr1,
 				ieee->current_network.bssid);
 		ether_addr_copy(header.addr2, src);
-		if (IsAmsdu)
-			ether_addr_copy(header.addr3,
-					ieee->current_network.bssid);
-		else
-			ether_addr_copy(header.addr3, dest);
+		ether_addr_copy(header.addr3, dest);
 	}
 
 	is_multicast = is_multicast_ether_addr(header.addr1);
-- 
2.30.2


  parent reply	other threads:[~2024-06-10  5:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  5:44 [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Tree Davies
2024-06-10  5:44 ` [PATCH 01/24] Staging: rtl8192e: Rename variable bHwSec Tree Davies
2024-06-10  5:44 ` [PATCH 02/24] Staging: rtl8192e: Rename variable bIsMulticast Tree Davies
2024-06-10  5:44 ` [PATCH 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Tree Davies
2024-06-10  5:44 ` [PATCH 04/24] Staging: rtl8192e: Rename variable HTOpMode Tree Davies
2024-06-10  5:44 ` [PATCH 05/24] Staging: rtl8192e: Rename variable bRTSEnable Tree Davies
2024-06-10  5:44 ` [PATCH 06/24] Staging: rtl8192e: Rename variable bRTSBW Tree Davies
2024-06-10  5:44 ` [PATCH 07/24] Staging: rtl8192e: Rename variable bCTSEnable Tree Davies
2024-06-10  5:44 ` [PATCH 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Tree Davies
2024-06-10  6:08   ` Dan Carpenter
2024-06-11  2:15     ` <Tree Davies
2024-06-11  5:18       ` Dan Carpenter
2024-06-10  5:44 ` [PATCH 10/24] Staging: rtl8192e: Rename variable bPacketBW Tree Davies
2024-06-10  5:44 ` [PATCH 11/24] Staging: rtl8192e: Rename variable bBroadcast Tree Davies
2024-06-10  5:44 ` [PATCH 12/24] Staging: rtl8192e: Rename variable CntAfterLink Tree Davies
2024-06-10  5:44 ` [PATCH 13/24] Staging: rtl8192e: Rename variable bUseShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Tree Davies
2024-06-10  5:44 ` [PATCH 15/24] Staging: rtl8192e: Fix spaces/tab alignment to match open parenthesis Tree Davies
2024-06-10  5:44 ` [PATCH 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Tree Davies
2024-06-10  5:44 ` [PATCH 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Tree Davies
2024-06-10  5:44 ` [PATCH 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Tree Davies
2024-06-10  5:44 ` [PATCH 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Tree Davies
2024-06-10  5:44 ` [PATCH 21/24] Remove parameter bIsAmsdu from rtllib_classify() Tree Davies
2024-06-10  5:44 ` Tree Davies [this message]
2024-06-10  5:44 ` [PATCH 23/24] Fix space/tab alignment to match open parenthesis in rtllib_tx.c Tree Davies
2024-06-10  5:44 ` [PATCH 24/24] Fix space/tab alignment to match open parenthesis in rtllib_rx.c Tree Davies
2024-06-10  6:25 ` [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610054449.71316-23-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=anjan@momi.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox