Linux kernel staging patches
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 05/24] Staging: rtl8192e: Rename variable bRTSEnable
Date: Sun,  9 Jun 2024 22:44:30 -0700	[thread overview]
Message-ID: <20240610054449.71316-6-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240610054449.71316-1-tdavies@darkphysics.net>

Rename variable bRTSEnable to rts_enable
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c |  2 +-
 drivers/staging/rtl8192e/rtllib.h              |  2 +-
 drivers/staging/rtl8192e/rtllib_tx.c           | 18 +++++++++---------
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 27dfa268cd68..0263f3d7179c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -892,7 +892,7 @@ void  rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
 		pTxFwInfo->RxAMD = 0;
 	}
 
-	pTxFwInfo->RtsEnable =	(cb_desc->bRTSEnable) ? 1 : 0;
+	pTxFwInfo->RtsEnable =	(cb_desc->rts_enable) ? 1 : 0;
 	pTxFwInfo->CtsEnable = (cb_desc->bCTSEnable) ? 1 : 0;
 	pTxFwInfo->RtsSTBC = (cb_desc->bRTSSTBC) ? 1 : 0;
 	pTxFwInfo->RtsHT = (cb_desc->rts_rate & 0x80) ? 1 : 0;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 6dc641f78202..a305848dabd5 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -111,7 +111,7 @@ struct cb_desc {
 
 	/* Tx Firmware Related flags (10-11)*/
 	u8 bCTSEnable:1;
-	u8 bRTSEnable:1;
+	u8 rts_enable:1;
 	u8 bUseShortGI:1;
 	u8 bUseShortPreamble:1;
 	u8 tx_enable_fw_calc_dur:1;
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 83082a990fbd..be8de6703e5d 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -386,10 +386,10 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,
 
 	if (ieee->mode < WIRELESS_MODE_N_24G) {
 		if (skb->len > ieee->rts) {
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			tcb_desc->rts_rate = MGN_24M;
 		} else if (ieee->current_network.buseprotection) {
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			tcb_desc->bCTSEnable = true;
 			tcb_desc->rts_rate = MGN_24M;
 		}
@@ -402,16 +402,16 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,
 		if (ht_info->iot_action & HT_IOT_ACT_FORCED_CTS2SELF) {
 			tcb_desc->bCTSEnable	= true;
 			tcb_desc->rts_rate  =	MGN_24M;
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			break;
 		} else if (ht_info->iot_action & (HT_IOT_ACT_FORCED_RTS |
 			   HT_IOT_ACT_PURE_N_MODE)) {
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			tcb_desc->rts_rate  =	MGN_24M;
 			break;
 		}
 		if (ieee->current_network.buseprotection) {
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			tcb_desc->bCTSEnable = true;
 			tcb_desc->rts_rate = MGN_24M;
 			break;
@@ -423,18 +423,18 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,
 						      ht_op_mode == 3)) ||
 			     (!ht_info->cur_bw_40mhz && ht_op_mode == 3)) {
 				tcb_desc->rts_rate = MGN_24M;
-				tcb_desc->bRTSEnable = true;
+				tcb_desc->rts_enable = true;
 				break;
 			}
 		}
 		if (skb->len > ieee->rts) {
 			tcb_desc->rts_rate = MGN_24M;
-			tcb_desc->bRTSEnable = true;
+			tcb_desc->rts_enable = true;
 			break;
 		}
 		if (tcb_desc->ampdu_enable) {
 			tcb_desc->rts_rate = MGN_24M;
-			tcb_desc->bRTSEnable = false;
+			tcb_desc->rts_enable = false;
 			break;
 		}
 		goto NO_PROTECTION;
@@ -443,7 +443,7 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,
 		tcb_desc->bUseShortPreamble = true;
 	return;
 NO_PROTECTION:
-	tcb_desc->bRTSEnable	= false;
+	tcb_desc->rts_enable	= false;
 	tcb_desc->bCTSEnable	= false;
 	tcb_desc->rts_rate	= 0;
 	tcb_desc->RTSSC		= 0;
-- 
2.30.2


  parent reply	other threads:[~2024-06-10  5:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  5:44 [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Tree Davies
2024-06-10  5:44 ` [PATCH 01/24] Staging: rtl8192e: Rename variable bHwSec Tree Davies
2024-06-10  5:44 ` [PATCH 02/24] Staging: rtl8192e: Rename variable bIsMulticast Tree Davies
2024-06-10  5:44 ` [PATCH 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Tree Davies
2024-06-10  5:44 ` [PATCH 04/24] Staging: rtl8192e: Rename variable HTOpMode Tree Davies
2024-06-10  5:44 ` Tree Davies [this message]
2024-06-10  5:44 ` [PATCH 06/24] Staging: rtl8192e: Rename variable bRTSBW Tree Davies
2024-06-10  5:44 ` [PATCH 07/24] Staging: rtl8192e: Rename variable bCTSEnable Tree Davies
2024-06-10  5:44 ` [PATCH 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Tree Davies
2024-06-10  6:08   ` Dan Carpenter
2024-06-11  2:15     ` <Tree Davies
2024-06-11  5:18       ` Dan Carpenter
2024-06-10  5:44 ` [PATCH 10/24] Staging: rtl8192e: Rename variable bPacketBW Tree Davies
2024-06-10  5:44 ` [PATCH 11/24] Staging: rtl8192e: Rename variable bBroadcast Tree Davies
2024-06-10  5:44 ` [PATCH 12/24] Staging: rtl8192e: Rename variable CntAfterLink Tree Davies
2024-06-10  5:44 ` [PATCH 13/24] Staging: rtl8192e: Rename variable bUseShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Tree Davies
2024-06-10  5:44 ` [PATCH 15/24] Staging: rtl8192e: Fix spaces/tab alignment to match open parenthesis Tree Davies
2024-06-10  5:44 ` [PATCH 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Tree Davies
2024-06-10  5:44 ` [PATCH 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Tree Davies
2024-06-10  5:44 ` [PATCH 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Tree Davies
2024-06-10  5:44 ` [PATCH 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Tree Davies
2024-06-10  5:44 ` [PATCH 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Tree Davies
2024-06-10  5:44 ` [PATCH 21/24] Remove parameter bIsAmsdu from rtllib_classify() Tree Davies
2024-06-10  5:44 ` [PATCH 22/24] Remove variable IsAmsdu from rtllib_xmit_inter() Tree Davies
2024-06-10  5:44 ` [PATCH 23/24] Fix space/tab alignment to match open parenthesis in rtllib_tx.c Tree Davies
2024-06-10  5:44 ` [PATCH 24/24] Fix space/tab alignment to match open parenthesis in rtllib_rx.c Tree Davies
2024-06-10  6:25 ` [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610054449.71316-6-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=anjan@momi.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox