[PATCH] staging: rtl8712: style fix multiple line dereference

[PATCH] staging: rtl8712: style fix multiple line dereference

[Moon Yeounsu]

It fix the following checkpatch.pl warning:
Avoid multiple line dereference - prefer %s

Signed-off-by: Moon Yeounsu <yyyynom@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_cmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index bbd4a13c7bb9..c8a220e04776 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -528,8 +528,7 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
 	if (unicast_key)
 		memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
 	else
-		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
-		       skey, 16);
+		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);
 	r8712_enqueue_cmd(pcmdpriv, ph2c);
 }
 
-- 
2.43.5

Re: [PATCH] staging: rtl8712: style fix multiple line dereference

[Philipp Hortmann]

On 7/17/24 15:06, Moon Yeounsu wrote:
> It fix the following checkpatch.pl warning:
> Avoid multiple line dereference - prefer %s
> 
> Signed-off-by: Moon Yeounsu <yyyynom@gmail.com>
> ---
>   drivers/staging/rtl8712/rtl871x_cmd.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> index bbd4a13c7bb9..c8a220e04776 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -528,8 +528,7 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
>   	if (unicast_key)
>   		memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
>   	else
> -		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
> -		       skey, 16);
> +		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);
>   	r8712_enqueue_cmd(pcmdpriv, ph2c);
>   }
>   
Hi Moon,

you did not use checkpatch on your patch:


kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ git commit 
--amend
WARNING: line length of 110 exceeds 100 columns
#21: FILE: drivers/staging/rtl8712/rtl871x_cmd.c:531:
+		memcpy(&psetstakey_para->key, 
&psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);

CHECK: Avoid CamelCase: <XGrpKey>
#21: FILE: drivers/staging/rtl8712/rtl871x_cmd.c:531:
+		memcpy(&psetstakey_para->key, 
&psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);

CHECK: Avoid CamelCase: <XGrpKeyid>
#21: FILE: drivers/staging/rtl8712/rtl871x_cmd.c:531:
+		memcpy(&psetstakey_para->key, 
&psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);

WARNING: From:/Signed-off-by: email address mismatch: 'From: Moon 
Yeounsu <yyyynoom@gmail.com>' != 'Signed-off-by: Moon Yeounsu 
<yyyynom@gmail.com>'

total: 0 errors, 2 warnings, 2 checks, 9 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
       mechanically convert to the typical style using --fix or 
--fix-inplace.

"[PATCH] staging: rtl8712: style fix multiple line dereference" has 
style problems, please review.

NOTE: If any of the errors are false positives, please report
       them to the maintainer, see CHECKPATCH in MAINTAINERS.
[staging-testing b055801a1388] staging: rtl8712: style fix multiple line 
dereference
  Author: Moon Yeounsu <yyyynoom@gmail.com>
  Date: Wed Jul 17 09:06:36 2024 -0400
  1 file changed, 1 insertion(+), 2 deletions(-)


The two warnings need to be fixed. But it is very difficult to fix the 
line break as you would need to shorten the line itself. May be you like 
to start with something else. Feel free to contact me directly for any 
question.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Bye Philipp

Re: [PATCH] staging: rtl8712: style fix multiple line dereference

[Dan Carpenter]

On Wed, Jul 17, 2024 at 09:48:55PM +0200, Philipp Hortmann wrote:
> The two warnings need to be fixed. But it is very difficult to fix the line
> break as you would need to shorten the line itself. May be you like to start
> with something else. Feel free to contact me directly for any question.

I would shorten it like below:

regards,
dan carpenter

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index bbd4a13c7bb9..ffeb91dd28c4 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -528,8 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
 	if (unicast_key)
 		memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
 	else
-		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
-		       skey, 16);
+		memcpy(&psetstakey_para->key,
+		       &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
+		       16);
 	r8712_enqueue_cmd(pcmdpriv, ph2c);
 }
 

[PATCH v2] staging: rtl8712: style fix multiple line dereference

[Moon Yeounsu]

It fix the following checkpatch.pl warning:
Avoid multiple line dereference - prefer %s

Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
---
v2: Fix email address and checkpatch.pl warning
---
 drivers/staging/rtl8712/rtl871x_cmd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index c8a220e04776..ffeb91dd28c4 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -528,7 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
 	if (unicast_key)
 		memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
 	else
-		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey, 16);
+		memcpy(&psetstakey_para->key,
+		       &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
+		       16);
 	r8712_enqueue_cmd(pcmdpriv, ph2c);
 }
 
-- 
2.43.5