From: Cruzer-S <yyyynoom@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com,
dan.carpenter@linaro.org, Moon Yeounsu <yyyynoom@gmail.com>
Subject: [PATCH v3] staging: rtl8712: style fix multiple line dereference
Date: Sun, 21 Jul 2024 00:05:04 -0400 [thread overview]
Message-ID: <20240721040504.1483-1-yyyynoom@gmail.com> (raw)
From: Moon Yeounsu <yyyynoom@gmail.com>
It fix the following checkpatch.pl warning:
Avoid multiple line dereference - prefer %s
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
---
v2: Fix email address and checkpatch.pl warning
v3: Fix incorrect commit index, start with new thread for new version of patch,
place notes below the cutoff line, provide appropriate CC,
include 'Suggested-by' sign for those who gives good guideline.
drivers/staging/rtl8712/rtl871x_cmd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index bbd4a13c7bb9..ffeb91dd28c4 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -528,8 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
if (unicast_key)
memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
else
- memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
- skey, 16);
+ memcpy(&psetstakey_para->key,
+ &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
+ 16);
r8712_enqueue_cmd(pcmdpriv, ph2c);
}
--
2.43.5
next reply other threads:[~2024-07-21 4:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 4:05 Cruzer-S [this message]
2024-07-21 4:43 ` [PATCH v3] staging: rtl8712: style fix multiple line dereference 문연수
2024-07-21 5:07 ` Nam Cao
2024-07-21 6:44 ` Moon Yeounsu
2024-07-23 15:22 ` Dan Carpenter
2024-07-23 16:02 ` Dan Carpenter
2024-07-23 17:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240721040504.1483-1-yyyynoom@gmail.com \
--to=yyyynoom@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox