Linux kernel staging patches
 help / color / mirror / Atom feed
From: Nam Cao <namcao@linutronix.de>
To: 문연수 <yyyynoom@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	philipp.g.hortmann@gmail.com, dan.carpenter@linaro.org
Subject: Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference
Date: Sun, 21 Jul 2024 07:07:42 +0200	[thread overview]
Message-ID: <20240721050717.dQ7Kwrkh@linutronix.de> (raw)
In-Reply-To: <CAAjsZQzTMtsX4bVqadG1ZKDt+8XLUOHGt0bkoBS+M8vqw-X5Bw@mail.gmail.com>

On Sun, Jul 21, 2024 at 01:43:37PM +0900, 문연수 wrote:
> 2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@gmail.com>님이 작성:
> > From: Moon Yeounsu <yyyynoom@gmail.com>
> >
> > It fix the following checkpatch.pl warning:
> > Avoid multiple line dereference - prefer %s
> >
> > Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
> > ---
> > v2: Fix email address and checkpatch.pl warning
> > v3: Fix incorrect commit index, start with new thread for new version of patch,
> >         place notes below the cutoff line, provide appropriate CC,
> >         include 'Suggested-by' sign for those who gives good guideline.

The "Suggested-by:" thingy is for patch idea, not for "guideline". Have a
look at Documentation/process/submitting-patches.rst.

...
> Sorry and thank you to all of the reviewers and maintainers who take
> care of my patch.
> I make a new problem... I think I check my patch and email over and
> over and over.
> but, again, I sent the patch incorrectly. The body of the patch
> contains improper content,
> and also sends the email as my nickname, not a real name.
> 
> Sorry for making spam and taking your invaluable time.
> Next time, I'll send a right and valuable patch.

Oh no worry, I'm sure people are happy to help. Linux's email-based
workflow is not the easiest to get right.

If you worry about "making spam", you could send the patch to yourself and
try "git am" the email. If it works then send it out for real.

Good luck,
Nam

  reply	other threads:[~2024-07-21  5:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-21  4:05 [PATCH v3] staging: rtl8712: style fix multiple line dereference Cruzer-S
2024-07-21  4:43 ` 문연수
2024-07-21  5:07   ` Nam Cao [this message]
2024-07-21  6:44     ` Moon Yeounsu
2024-07-23 15:22 ` Dan Carpenter
2024-07-23 16:02   ` Dan Carpenter
2024-07-23 17:34     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240721050717.dQ7Kwrkh@linutronix.de \
    --to=namcao@linutronix.de \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=yyyynoom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox