[PATCH] staging: rtl8723bs: Fix spacing issues

[PATCH] staging: rtl8723bs: Fix spacing issues

[Benjamin Somers]

This patch fixes spacing issues reported by checkpatch on lines 39-40

Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>

---
This is my first patch to the kernel
---
---
 drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
index 188ed7e26..e470abfc2 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
@@ -36,8 +36,8 @@
 	#include <linux/list.h>
 	#include <linux/vmalloc.h>
 
-/* 	#include <linux/ieee80211.h> */
-        #include <net/ieee80211_radiotap.h>
+	/* #include <linux/ieee80211.h> */
+	#include <net/ieee80211_radiotap.h>
 	#include <net/cfg80211.h>
 
 	struct	__queue	{
-- 
2.20.1

Re: [PATCH] staging: rtl8723bs: Fix spacing issues

[Greg KH]

On Tue, Jul 30, 2024 at 06:47:45AM +0000, Benjamin Somers wrote:
> This patch fixes spacing issues reported by checkpatch on lines 39-40
> 
> Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>
> 
> ---
> This is my first patch to the kernel
> ---
> ---
>  drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> index 188ed7e26..e470abfc2 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> @@ -36,8 +36,8 @@
>  	#include <linux/list.h>
>  	#include <linux/vmalloc.h>
>  
> -/* 	#include <linux/ieee80211.h> */
> -        #include <net/ieee80211_radiotap.h>
> +	/* #include <linux/ieee80211.h> */
> +	#include <net/ieee80211_radiotap.h>

Why not just remove the commented out line entirely?

And this is indented way too much, something went wrong :(

thanks,

greg k-h

[PATCH] staging: rtl8723bs: Fix spacing issues

[Benjamin Somers]

This patch removes superfluous tabs at the beginning of the file and
commented includes

Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>

---
This is my first patch to the kernel
---
 .../rtl8723bs/include/osdep_service_linux.h   | 72 +++++++++----------
 1 file changed, 35 insertions(+), 37 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
index 188ed7e26..2ec54f9e1 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
@@ -7,43 +7,41 @@
 #ifndef __OSDEP_LINUX_SERVICE_H_
 #define __OSDEP_LINUX_SERVICE_H_
 
-	#include <linux/spinlock.h>
-	#include <linux/compiler.h>
-	#include <linux/kernel.h>
-	#include <linux/errno.h>
-	#include <linux/init.h>
-	#include <linux/slab.h>
-	#include <linux/module.h>
-	#include <linux/kref.h>
-	/* include <linux/smp_lock.h> */
-	#include <linux/netdevice.h>
-	#include <linux/skbuff.h>
-	#include <linux/uaccess.h>
-	#include <asm/byteorder.h>
-	#include <linux/atomic.h>
-	#include <linux/io.h>
-	#include <linux/sem.h>
-	#include <linux/sched.h>
-	#include <linux/etherdevice.h>
-	#include <linux/wireless.h>
-	#include <net/iw_handler.h>
-	#include <linux/if_arp.h>
-	#include <linux/rtnetlink.h>
-	#include <linux/delay.h>
-	#include <linux/interrupt.h>	/*  for struct tasklet_struct */
-	#include <linux/ip.h>
-	#include <linux/kthread.h>
-	#include <linux/list.h>
-	#include <linux/vmalloc.h>
-
-/* 	#include <linux/ieee80211.h> */
-        #include <net/ieee80211_radiotap.h>
-	#include <net/cfg80211.h>
-
-	struct	__queue	{
-		struct	list_head	queue;
-		spinlock_t	lock;
-	};
+#include <linux/spinlock.h>
+#include <linux/compiler.h>
+#include <linux/kernel.h>
+#include <linux/errno.h>
+#include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/module.h>
+#include <linux/kref.h>
+#include <linux/netdevice.h>
+#include <linux/skbuff.h>
+#include <linux/uaccess.h>
+#include <asm/byteorder.h>
+#include <linux/atomic.h>
+#include <linux/io.h>
+#include <linux/sem.h>
+#include <linux/sched.h>
+#include <linux/etherdevice.h>
+#include <linux/wireless.h>
+#include <net/iw_handler.h>
+#include <linux/if_arp.h>
+#include <linux/rtnetlink.h>
+#include <linux/delay.h>
+#include <linux/interrupt.h>	/*  for struct tasklet_struct */
+#include <linux/ip.h>
+#include <linux/kthread.h>
+#include <linux/list.h>
+#include <linux/vmalloc.h>
+
+#include <net/ieee80211_radiotap.h>
+#include <net/cfg80211.h>
+
+struct	__queue	{
+	struct	list_head	queue;
+	spinlock_t	lock;
+};
 
 static inline struct list_head *get_next(struct list_head	*list)
 {
-- 
2.20.1

Re: [PATCH] staging: rtl8723bs: Fix spacing issues

[Dan Carpenter]

On Tue, Jul 30, 2024 at 07:05:18AM +0000, Benjamin Somers wrote:
> This patch removes superfluous tabs at the beginning of the file and
> commented includes
> 

Please do this as two patches.  Patch 1 delete the commented includes.
Patch 2 delete the tabs.

regards,
dan carpenter