From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Renan M. S. Florencio" <renanm.florencio@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c
Date: Thu, 22 Aug 2024 15:50:54 +0800 [thread overview]
Message-ID: <2024082226-yin-tug-eca5@gregkh> (raw)
In-Reply-To: <20240822002526.19757-1-renanm.florencio@gmail.com>
On Wed, Aug 21, 2024 at 09:25:26PM -0300, Renan M. S. Florencio wrote:
> Fix indentation in r8192E_dev.c to silence checkpatch warnings:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Renan M. S. Florencio <renanm.florencio@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b3d4b3394284..ec867801bfbd 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1741,7 +1741,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
> ieee->ht_info->cur_short_gi_40mhz)
> ratr_value |= 0x80000000;
> else if (!ieee->ht_info->cur_tx_bw40mhz &&
> - ieee->ht_info->cur_short_gi_20mhz)
> + ieee->ht_info->cur_short_gi_20mhz)
But the alignment does not now match, are you sure you ran your change
through checkpatch to verify it did what you thought it did?
thanks,
greg k-h
prev parent reply other threads:[~2024-08-22 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 0:25 [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c Renan M. S. Florencio
2024-08-22 7:50 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024082226-yin-tug-eca5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=renanm.florencio@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox