* [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c
@ 2024-08-22 0:25 Renan M. S. Florencio
2024-08-22 7:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Renan M. S. Florencio @ 2024-08-22 0:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel, ~lkcamp/patches
Fix indentation in r8192E_dev.c to silence checkpatch warnings:
CHECK: Alignment should match open parenthesis
Signed-off-by: Renan M. S. Florencio <renanm.florencio@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b3d4b3394284..ec867801bfbd 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1741,7 +1741,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
ieee->ht_info->cur_short_gi_40mhz)
ratr_value |= 0x80000000;
else if (!ieee->ht_info->cur_tx_bw40mhz &&
- ieee->ht_info->cur_short_gi_20mhz)
+ ieee->ht_info->cur_short_gi_20mhz)
ratr_value |= 0x80000000;
rtl92e_writel(dev, RATR0 + rate_index * 4, ratr_value);
rtl92e_writeb(dev, UFWP, 1);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c
2024-08-22 0:25 [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c Renan M. S. Florencio
@ 2024-08-22 7:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-22 7:50 UTC (permalink / raw)
To: Renan M. S. Florencio; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Wed, Aug 21, 2024 at 09:25:26PM -0300, Renan M. S. Florencio wrote:
> Fix indentation in r8192E_dev.c to silence checkpatch warnings:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Renan M. S. Florencio <renanm.florencio@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b3d4b3394284..ec867801bfbd 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1741,7 +1741,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
> ieee->ht_info->cur_short_gi_40mhz)
> ratr_value |= 0x80000000;
> else if (!ieee->ht_info->cur_tx_bw40mhz &&
> - ieee->ht_info->cur_short_gi_20mhz)
> + ieee->ht_info->cur_short_gi_20mhz)
But the alignment does not now match, are you sure you ran your change
through checkpatch to verify it did what you thought it did?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-22 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 0:25 [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c Renan M. S. Florencio
2024-08-22 7:50 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox