* [PATCH] staging: greybus: Enclose multi-statement Macro in a do-while loop
@ 2024-08-26 8:32 Dorine Tipo
2024-08-26 8:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Dorine Tipo @ 2024-08-26 8:32 UTC (permalink / raw)
To: Greg Kroah-Hartman, Bryan O'Donoghue, Johan Hovold,
Alex Elder, greybus-dev, linux-staging, Shuah Khan,
Javier Carrasco
Cc: Dorine Tipo
Update the gb_loopback_stats_attrs() macro to use a do-while(0) loop.
This ensures that it is treated as a single statement, preventing
potential issues when used in conditional or loop constructs.
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
drivers/staging/greybus/loopback.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 1f19323b0e1a..0f3e4c43e2de 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \
static DEVICE_ATTR_RO(name##_avg)
#define gb_loopback_stats_attrs(field) \
- gb_loopback_ro_stats_attr(field, min, u); \
- gb_loopback_ro_stats_attr(field, max, u); \
- gb_loopback_ro_avg_attr(field)
+ do {
+ gb_loopback_ro_stats_attr(field, min, u); \
+ gb_loopback_ro_stats_attr(field, max, u); \
+ gb_loopback_ro_avg_attr(field);
+ } while (0)
#define gb_loopback_attr(field, type) \
static ssize_t field##_show(struct device *dev, \
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: greybus: Enclose multi-statement Macro in a do-while loop
2024-08-26 8:32 [PATCH] staging: greybus: Enclose multi-statement Macro in a do-while loop Dorine Tipo
@ 2024-08-26 8:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-26 8:36 UTC (permalink / raw)
To: Dorine Tipo
Cc: Bryan O'Donoghue, Johan Hovold, Alex Elder, greybus-dev,
linux-staging, Shuah Khan, Javier Carrasco
On Mon, Aug 26, 2024 at 08:32:12AM +0000, Dorine Tipo wrote:
> Update the gb_loopback_stats_attrs() macro to use a do-while(0) loop.
> This ensures that it is treated as a single statement, preventing
> potential issues when used in conditional or loop constructs.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index 1f19323b0e1a..0f3e4c43e2de 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \
> static DEVICE_ATTR_RO(name##_avg)
>
> #define gb_loopback_stats_attrs(field) \
> - gb_loopback_ro_stats_attr(field, min, u); \
> - gb_loopback_ro_stats_attr(field, max, u); \
> - gb_loopback_ro_avg_attr(field)
> + do {
> + gb_loopback_ro_stats_attr(field, min, u); \
> + gb_loopback_ro_stats_attr(field, max, u); \
> + gb_loopback_ro_avg_attr(field);
> + } while (0)
>
Please always test-build your patches before sending them out :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 8:32 [PATCH] staging: greybus: Enclose multi-statement Macro in a do-while loop Dorine Tipo
2024-08-26 8:36 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox