From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xingquan Liu <b1n@b1n.io>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings
Date: Fri, 27 Sep 2024 20:36:35 +0200 [thread overview]
Message-ID: <2024092735-domain-sharply-cfb2@gregkh> (raw)
In-Reply-To: <20240927151637.82772-1-b1n@b1n.io>
On Fri, Sep 27, 2024 at 11:16:36PM +0800, Xingquan Liu wrote:
> Fix all unnecessary parentheses warnings in checkpath.
That's not what this commit does at all.
> Signed-off-by: Xingquan Liu <b1n@b1n.io>
> ---
> I ran clang-format additionally because I noticed the Linux community
> recommends submitting code formatting patches along with other patches.
No they do not at all, where was that written down, it needs to be
changed.
> I'm not sure if there are any issues with this.
so many issues, would you take a patch that did this? (hint, I will
not...)
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-27 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 15:16 [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings Xingquan Liu
2024-09-27 15:26 ` Dan Carpenter
2024-09-27 15:36 ` Xingquan Liu
2024-09-27 15:45 ` Dan Carpenter
2024-09-27 15:53 ` Xingquan Liu
2024-09-27 18:36 ` Greg Kroah-Hartman [this message]
2024-09-27 21:46 ` Xingquan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024092735-domain-sharply-cfb2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=b1n@b1n.io \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox