From: "Xingquan Liu" <b1n@b1n.io>
To: "Dan Carpenter" <dan.carpenter@linaro.org>
Cc: "Florian Schilhabel" <florian.c.schilhabel@googlemail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings
Date: Fri, 27 Sep 2024 15:53:37 +0000 [thread overview]
Message-ID: <D4H6RX1ZCSQ8.1BQ8LW44D65X1@b1n.io> (raw)
In-Reply-To: <75267b21-f800-41a5-8a7a-ddbf0062ffcd@stanley.mountain>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Fri Sep 27, 2024 at 11:45 PM CST, Dan Carpenter wrote:
> Greg doesn't agree with checkpatch about unnecessary parentheses. If the code
> looks like this:
>
> if ((a == b) || (b == c)) {
>
> then just ignore checkpatch. However if the code looks like:
>
> p = &(foo);
>
> Then change it to:
>
> p = &foo;
>
> This sort of change would need to be split up by driver instead of all of
> driver/staging. So it would be a series of patches. You don't need to split
> it up by file. Split it by driver.
Thanks, this information is important.
--
Xingquan Liu
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 350 bytes --]
next prev parent reply other threads:[~2024-09-27 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 15:16 [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings Xingquan Liu
2024-09-27 15:26 ` Dan Carpenter
2024-09-27 15:36 ` Xingquan Liu
2024-09-27 15:45 ` Dan Carpenter
2024-09-27 15:53 ` Xingquan Liu [this message]
2024-09-27 18:36 ` Greg Kroah-Hartman
2024-09-27 21:46 ` Xingquan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4H6RX1ZCSQ8.1BQ8LW44D65X1@b1n.io \
--to=b1n@b1n.io \
--cc=dan.carpenter@linaro.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox