* [PATCH 1/4] drivers: staging: rtl8723bs: Fix braces coding style issue.
2024-10-16 12:56 [PATCH 0/4] Fix coding style issues Aymen Khalfa
@ 2024-10-16 12:56 ` Aymen Khalfa
2024-10-16 14:29 ` Dan Carpenter
2024-10-16 12:56 ` [PATCH 2/4] drivers: staging: rtl8723bs: Fix space " Aymen Khalfa
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Aymen Khalfa @ 2024-10-16 12:56 UTC (permalink / raw)
To: gregkh, hdegoede, Larry.Finger; +Cc: linux-staging, Aymen Khalfa
- Remove unnecessary braces.
Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index dbfcbac3d855..1ced6f7ac552 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
pwrpriv->ips_leave_cnts++;
result = rtw_ips_pwr_up(padapter);
- if (result == _SUCCESS) {
+ if (result == _SUCCESS)
pwrpriv->rf_pwrstate = rf_on;
- }
+
pwrpriv->bips_processing = false;
pwrpriv->bkeepfwalive = false;
@@ -556,9 +556,9 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
LPS_Leave_check(Adapter);
} else {
- if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
+ if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
ips_leave(Adapter);
- }
+
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/4] drivers: staging: rtl8723bs: Fix braces coding style issue.
2024-10-16 12:56 ` [PATCH 1/4] drivers: staging: rtl8723bs: Fix braces coding style issue Aymen Khalfa
@ 2024-10-16 14:29 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2024-10-16 14:29 UTC (permalink / raw)
To: Aymen Khalfa; +Cc: gregkh, hdegoede, Larry.Finger, linux-staging
On Wed, Oct 16, 2024 at 02:56:27PM +0200, Aymen Khalfa wrote:
> - Remove unnecessary braces.
>
> Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index dbfcbac3d855..1ced6f7ac552 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
> pwrpriv->ips_leave_cnts++;
>
> result = rtw_ips_pwr_up(padapter);
> - if (result == _SUCCESS) {
> + if (result == _SUCCESS)
> pwrpriv->rf_pwrstate = rf_on;
> - }
> +
> pwrpriv->bips_processing = false;
>
> pwrpriv->bkeepfwalive = false;
> @@ -556,9 +556,9 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
>
> LPS_Leave_check(Adapter);
> } else {
> - if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
> + if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
> ips_leave(Adapter);
> - }
> +
> }
It's against the style rules to have a blank line before a } close parenthesis.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4] drivers: staging: rtl8723bs: Fix space coding style issue.
2024-10-16 12:56 [PATCH 0/4] Fix coding style issues Aymen Khalfa
2024-10-16 12:56 ` [PATCH 1/4] drivers: staging: rtl8723bs: Fix braces coding style issue Aymen Khalfa
@ 2024-10-16 12:56 ` Aymen Khalfa
2024-10-16 14:30 ` Dan Carpenter
2024-10-16 12:56 ` [PATCH 3/4] drivers: staging: rtl8723bs: Fix missing blank line after declaration " Aymen Khalfa
2024-10-16 12:56 ` [PATCH 4/4] drivers: staging: rtl8723bs: Fix comment alignment " Aymen Khalfa
3 siblings, 1 reply; 7+ messages in thread
From: Aymen Khalfa @ 2024-10-16 12:56 UTC (permalink / raw)
To: gregkh, hdegoede, Larry.Finger; +Cc: linux-staging, Aymen Khalfa
- Remove unnecessary space before tab.
Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 1ced6f7ac552..56a85174965c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -436,8 +436,8 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
}
/* */
-/* Description: */
-/* Enter the leisure power save mode. */
+/* Description: */
+/* Enter the leisure power save mode. */
/* */
void LPS_Enter(struct adapter *padapter, const char *msg)
{
@@ -476,8 +476,8 @@ void LPS_Enter(struct adapter *padapter, const char *msg)
}
/* */
-/* Description: */
-/* Leave the leisure power save mode. */
+/* Description: */
+/* Leave the leisure power save mode. */
/* */
void LPS_Leave(struct adapter *padapter, const char *msg)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] drivers: staging: rtl8723bs: Fix space coding style issue.
2024-10-16 12:56 ` [PATCH 2/4] drivers: staging: rtl8723bs: Fix space " Aymen Khalfa
@ 2024-10-16 14:30 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2024-10-16 14:30 UTC (permalink / raw)
To: Aymen Khalfa; +Cc: gregkh, hdegoede, Larry.Finger, linux-staging
On Wed, Oct 16, 2024 at 02:56:28PM +0200, Aymen Khalfa wrote:
> - Remove unnecessary space before tab.
>
> Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index 1ced6f7ac552..56a85174965c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -436,8 +436,8 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> }
>
> /* */
> -/* Description: */
> -/* Enter the leisure power save mode. */
> +/* Description: */
> +/* Enter the leisure power save mode. */
> /* */
This isn't proper kernel style. This is a networking driver so the style is
slightly different for networking.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/4] drivers: staging: rtl8723bs: Fix missing blank line after declaration coding style issue.
2024-10-16 12:56 [PATCH 0/4] Fix coding style issues Aymen Khalfa
2024-10-16 12:56 ` [PATCH 1/4] drivers: staging: rtl8723bs: Fix braces coding style issue Aymen Khalfa
2024-10-16 12:56 ` [PATCH 2/4] drivers: staging: rtl8723bs: Fix space " Aymen Khalfa
@ 2024-10-16 12:56 ` Aymen Khalfa
2024-10-16 12:56 ` [PATCH 4/4] drivers: staging: rtl8723bs: Fix comment alignment " Aymen Khalfa
3 siblings, 0 replies; 7+ messages in thread
From: Aymen Khalfa @ 2024-10-16 12:56 UTC (permalink / raw)
To: gregkh, hdegoede, Larry.Finger; +Cc: linux-staging, Aymen Khalfa
- Add a blank line after declaring struct.
Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 56a85174965c..cc4d08ce1d2e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -1011,6 +1011,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
{
struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
+
pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/4] drivers: staging: rtl8723bs: Fix comment alignment coding style issue.
2024-10-16 12:56 [PATCH 0/4] Fix coding style issues Aymen Khalfa
` (2 preceding siblings ...)
2024-10-16 12:56 ` [PATCH 3/4] drivers: staging: rtl8723bs: Fix missing blank line after declaration " Aymen Khalfa
@ 2024-10-16 12:56 ` Aymen Khalfa
3 siblings, 0 replies; 7+ messages in thread
From: Aymen Khalfa @ 2024-10-16 12:56 UTC (permalink / raw)
To: gregkh, hdegoede, Larry.Finger; +Cc: linux-staging, Aymen Khalfa
- Align * on block comment.
Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index cc4d08ce1d2e..5566c01193fe 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -1016,11 +1016,11 @@ inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
}
/*
-* rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend
-* @adapter: pointer to struct adapter structure
-* @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup
-* Return _SUCCESS or _FAIL
-*/
+ * rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend
+ * @adapter: pointer to struct adapter structure
+ * @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup
+ * Return _SUCCESS or _FAIL
+ */
int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *caller)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread