[PATCH] staging: gpib: Remove unneeded semicolon.

[PATCH] staging: gpib: Remove unneeded semicolon.

[Rohit Chavan]

This patch cleans up the GPIB driver code by removing
unneeded semicolons.

Files modified:
drivers/staging/gpib/tms9914/tms9914.c
drivers/staging/gpib/tnt4882/mite.c

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
 drivers/staging/gpib/tms9914/tms9914.c | 4 ++--
 drivers/staging/gpib/tnt4882/mite.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gpib/tms9914/tms9914.c b/drivers/staging/gpib/tms9914/tms9914.c
index aa2308cf5477..6d75294412d8 100644
--- a/drivers/staging/gpib/tms9914/tms9914.c
+++ b/drivers/staging/gpib/tms9914/tms9914.c
@@ -439,7 +439,7 @@ static int wait_for_read_byte(gpib_board_t *board, struct tms9914_priv *priv)
 				     test_bit(TIMO_NUM, &board->status))) {
 		pr_debug("gpib: pio read wait interrupted\n");
 		return -ERESTARTSYS;
-	};
+	}
 	if (test_bit(TIMO_NUM, &board->status))
 		return -ETIMEDOUT;
 
@@ -473,7 +473,7 @@ static inline uint8_t tms9914_read_data_in(gpib_board_t *board, struct tms9914_p
 	default:
 		pr_err("%s: bug! bad holdoff mode %i\n", __func__, priv->holdoff_mode);
 		break;
-	};
+	}
 	spin_unlock_irqrestore(&board->spinlock, flags);
 
 	return data;
diff --git a/drivers/staging/gpib/tnt4882/mite.c b/drivers/staging/gpib/tnt4882/mite.c
index adb656a5eb2c..882cc4bc122e 100644
--- a/drivers/staging/gpib/tnt4882/mite.c
+++ b/drivers/staging/gpib/tnt4882/mite.c
@@ -82,7 +82,7 @@ int mite_setup(struct mite_struct *mite)
 	if (pci_request_regions(mite->pcidev, "mite")) {
 		pr_err("mite: failed to request mite io regions.\n");
 		return -EIO;
-	};
+	}
 	addr = pci_resource_start(mite->pcidev, 0);
 	mite->mite_phys_addr = addr;
 	mite->mite_io_addr = ioremap(addr, pci_resource_len(mite->pcidev, 0));
-- 
2.34.1

Re: [PATCH] staging: gpib: Remove unneeded semicolon.

[Greg Kroah-Hartman]

On Wed, Oct 16, 2024 at 12:49:41PM +0530, Rohit Chavan wrote:
> This patch cleans up the GPIB driver code by removing
> unneeded semicolons.

Nit, you can use all 72 columns.

> 
> Files modified:
> drivers/staging/gpib/tms9914/tms9914.c
> drivers/staging/gpib/tnt4882/mite.c

Why are these lines needed?  We know what files are modified by looking
at the diff :)

Please fix up and send a v2.

thanks,

greg k-