* [PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order
@ 2024-12-11 19:22 eisantosh95
2024-12-11 20:01 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: eisantosh95 @ 2024-12-11 19:22 UTC (permalink / raw)
Cc: eisantosh95, Dave Penkler, Greg Kroah-Hartman, Dan Carpenter,
Arnd Bergmann, Rohit Chavan, linux-staging, linux-kernel
From: Santosh Mahto <eisantosh95@gmail.com>
ERROR found by checkpatch.pl script
Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
---
drivers/staging/gpib/gpio/gpib_bitbang.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index a2d562cbd65b..3aec39a6d6b5 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -44,10 +44,10 @@
pr_info("%s:%s - " frm, NAME, __func__, ## __VA_ARGS__); } \
while (0)
-#define LINVAL gpiod_get_value(DAV), \
- gpiod_get_value(NRFD), \
- gpiod_get_value(NDAC), \
- gpiod_get_value(SRQ)
+#define LINVAL (gpiod_get_value(DAV), \
+ gpiod_get_value(NRFD), \
+ gpiod_get_value(NDAC), \
+ gpiod_get_value(SRQ))
#define LINFMT "DAV: %d NRFD:%d NDAC: %d SRQ: %d"
#include "gpibP.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order
2024-12-11 19:22 [PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order eisantosh95
@ 2024-12-11 20:01 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-12-11 20:01 UTC (permalink / raw)
To: eisantosh95
Cc: Dave Penkler, Greg Kroah-Hartman, Arnd Bergmann, Rohit Chavan,
linux-staging, linux-kernel
On Thu, Dec 12, 2024 at 12:52:04AM +0530, eisantosh95@gmail.com wrote:
> From: Santosh Mahto <eisantosh95@gmail.com>
>
> ERROR found by checkpatch.pl script
>
> Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
> ---
Checkpatch isn't always right. Adding parentheses breaks the build.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-11 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 19:22 [PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order eisantosh95
2024-12-11 20:01 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox