* [PATCH] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
@ 2025-03-03 18:05 Saalim Quadri
2025-03-04 14:32 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Saalim Quadri @ 2025-03-03 18:05 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-kernel,
linux-staging, Saalim Quadri
* Since we are making use of devm_iio_device_register(), we no longer
need this nor do we have any spi_get_drvdata() in the driver.
Signed-off-by: Saalim Quadri <danascape@gmail.com>
---
drivers/staging/iio/accel/adis16203.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index c1c73308800c..3faf3c61046a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
if (!indio_dev)
return -ENOMEM;
st = iio_priv(indio_dev);
- /* this is only used for removal purposes */
- spi_set_drvdata(spi, indio_dev);
indio_dev->name = spi->dev.driver->name;
indio_dev->channels = adis16203_channels;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
2025-03-03 18:05 [PATCH] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
@ 2025-03-04 14:32 ` Jonathan Cameron
2025-03-05 23:50 ` Saalim Quadri
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2025-03-04 14:32 UTC (permalink / raw)
To: Saalim Quadri
Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-kernel,
linux-staging
On Mon, 3 Mar 2025 23:35:23 +0530
Saalim Quadri <danascape@gmail.com> wrote:
> * Since we are making use of devm_iio_device_register(), we no longer
> need this nor do we have any spi_get_drvdata() in the driver.
>
Why have a single bullet point?
Also please rewrite in imperative sense. Something like
Driver no longer has a remove callback after conversion to fully
devm_ managed probe(). Remove now unneeded spi_get_drvdata()
as that value was previously on read in the remove() callback.
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
Code is fine, so just this patch description stuff.
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16203.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index c1c73308800c..3faf3c61046a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
> if (!indio_dev)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> - /* this is only used for removal purposes */
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->channels = adis16203_channels;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-05 23:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-03 18:05 [PATCH] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
2025-03-04 14:32 ` Jonathan Cameron
2025-03-05 23:50 ` Saalim Quadri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox