* [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.
@ 2025-05-07 10:42 Rujra Bhatt
2025-05-07 11:13 ` Greg KH
2025-05-07 11:24 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Rujra Bhatt @ 2025-05-07 10:42 UTC (permalink / raw)
To: dpenkler, gregkh; +Cc: linux-staging, linux-kernel
Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
---
drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index b326058a10c0..94bbb3b6576d 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -479,7 +479,7 @@ static void agilent_82350b_return_to_local(struct gpib_board *board)
static int agilent_82350b_allocate_private(struct gpib_board *board)
{
- board->private_data = kzalloc(sizeof(struct * board->private_data), GFP_KERNEL);
+ board->private_data = kzalloc(sizeof(struct agilent_82350b_priv), GFP_KERNEL);
if (!board->private_data)
return -ENOMEM;
return 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.
2025-05-07 10:42 [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size Rujra Bhatt
@ 2025-05-07 11:13 ` Greg KH
2025-05-07 11:24 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-05-07 11:13 UTC (permalink / raw)
To: Rujra Bhatt; +Cc: dpenkler, linux-staging, linux-kernel
On Wed, May 07, 2025 at 04:12:57PM +0530, Rujra Bhatt wrote:
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
> ---
> drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Something went really wrong with your subject line :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.
2025-05-07 10:42 [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size Rujra Bhatt
2025-05-07 11:13 ` Greg KH
@ 2025-05-07 11:24 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-05-07 11:24 UTC (permalink / raw)
To: Rujra Bhatt; +Cc: dpenkler, gregkh, linux-staging, linux-kernel
I think you sent an incorrect patch earlier and you're trying to revert
that patch now? We never applied the patch so there is no need.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-07 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-07 10:42 [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size Rujra Bhatt
2025-05-07 11:13 ` Greg KH
2025-05-07 11:24 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox