* [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
@ 2025-05-22 3:15 Donny Turizo
2025-05-22 4:42 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Donny Turizo @ 2025-05-22 3:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Donny-Dev
From: Donny-Dev <donnyturizo13@gmail.com>
Fixes a checkpath warning by renaming the function
_Read_EEPROM to follow the kernel coding style (snake_case).
Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 49bcefb5e8d2..a0b85beffe5d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
{GEN_CMD_CODE(_Write_BBREG), NULL},
{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
- {GEN_CMD_CODE(_Read_EEPROM), NULL},
+ {GEN_CMD_CODE(_read_eeprom), NULL},
{GEN_CMD_CODE(_Write_EEPROM), NULL},
{GEN_CMD_CODE(_Read_EFUSE), NULL},
{GEN_CMD_CODE(_Write_EFUSE), NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index cb44119ce9a9..e4e7e350d0fc 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -636,7 +636,7 @@ enum {
GEN_CMD_CODE(_Write_BBREG),
GEN_CMD_CODE(_Read_RFREG),
GEN_CMD_CODE(_Write_RFREG), /*5*/
- GEN_CMD_CODE(_Read_EEPROM),
+ GEN_CMD_CODE(_read_eeprom),
GEN_CMD_CODE(_Write_EEPROM),
GEN_CMD_CODE(_Read_EFUSE),
GEN_CMD_CODE(_Write_EFUSE),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 2080408743ef..63373d665d4f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -684,7 +684,7 @@ enum {
GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
GEN_EVT_CODE(_Read_BBREG),
GEN_EVT_CODE(_Read_RFREG),
- GEN_EVT_CODE(_Read_EEPROM),
+ GEN_EVT_CODE(_read_eeprom),
GEN_EVT_CODE(_Read_EFUSE),
GEN_EVT_CODE(_Read_CAM), /*5*/
GEN_EVT_CODE(_Get_BasicRate),
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
2025-05-22 3:15 [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom Donny Turizo
@ 2025-05-22 4:42 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2025-05-22 4:42 UTC (permalink / raw)
To: Donny Turizo; +Cc: linux-staging, linux-kernel
On Thu, May 22, 2025 at 03:15:38AM +0000, Donny Turizo wrote:
> From: Donny-Dev <donnyturizo13@gmail.com>
>
> Fixes a checkpath warning by renaming the function
> _Read_EEPROM to follow the kernel coding style (snake_case).
Why just this one?
>
> Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 49bcefb5e8d2..a0b85beffe5d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> {GEN_CMD_CODE(_Write_BBREG), NULL},
> {GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
> {GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
> - {GEN_CMD_CODE(_Read_EEPROM), NULL},
> + {GEN_CMD_CODE(_read_eeprom), NULL},
Are you sure this is correct? Aren't these commands that come from the
hardware and show up on a datasheet somewhere? Don't rename things that
are referenced outside of the kernel in a different way if at all
possible.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
@ 2025-05-22 3:50 Donny Turizo
2025-05-22 4:44 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Donny Turizo @ 2025-05-22 3:50 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Donny Turizo
Fixes a checkpath warning by renaming the function
_Read_EEPROM to follow the kernel coding style (snake_case).
Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 49bcefb5e8d2..a0b85beffe5d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
{GEN_CMD_CODE(_Write_BBREG), NULL},
{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
- {GEN_CMD_CODE(_Read_EEPROM), NULL},
+ {GEN_CMD_CODE(_read_eeprom), NULL},
{GEN_CMD_CODE(_Write_EEPROM), NULL},
{GEN_CMD_CODE(_Read_EFUSE), NULL},
{GEN_CMD_CODE(_Write_EFUSE), NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index cb44119ce9a9..e4e7e350d0fc 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -636,7 +636,7 @@ enum {
GEN_CMD_CODE(_Write_BBREG),
GEN_CMD_CODE(_Read_RFREG),
GEN_CMD_CODE(_Write_RFREG), /*5*/
- GEN_CMD_CODE(_Read_EEPROM),
+ GEN_CMD_CODE(_read_eeprom),
GEN_CMD_CODE(_Write_EEPROM),
GEN_CMD_CODE(_Read_EFUSE),
GEN_CMD_CODE(_Write_EFUSE),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 2080408743ef..63373d665d4f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -684,7 +684,7 @@ enum {
GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
GEN_EVT_CODE(_Read_BBREG),
GEN_EVT_CODE(_Read_RFREG),
- GEN_EVT_CODE(_Read_EEPROM),
+ GEN_EVT_CODE(_read_eeprom),
GEN_EVT_CODE(_Read_EFUSE),
GEN_EVT_CODE(_Read_CAM), /*5*/
GEN_EVT_CODE(_Get_BasicRate),
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
2025-05-22 3:50 Donny Turizo
@ 2025-05-22 4:44 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2025-05-22 4:44 UTC (permalink / raw)
To: Donny Turizo; +Cc: linux-staging, linux-kernel
On Thu, May 22, 2025 at 03:50:03AM +0000, Donny Turizo wrote:
> Fixes a checkpath warning by renaming the function
> _Read_EEPROM to follow the kernel coding style (snake_case).
>
> Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
You seem to be sending many patches over and over, please do not do
that. Resend them only once please, and also, properly version your
patches as is documented, if you do resend them. As it is, I don't know
what to review here, so I'll just delete them all from my review queue
and wait for new versions, properly updated, to be resent later.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
@ 2025-05-20 22:26 Donny-Dev
2025-05-21 4:21 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Donny-Dev @ 2025-05-20 22:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Donny-Dev
This patch fixes a checkpatch
warning by renaming the function
_Read_EEPROM to follow the
kernel coding style (snake_case).
Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 1c9e8b01d..557bfdf09 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
{GEN_CMD_CODE(_Write_BBREG), NULL},
{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
- {GEN_CMD_CODE(_Read_EEPROM), NULL},
+ {GEN_CMD_CODE(_read_eeprom), NULL},
{GEN_CMD_CODE(_Write_EEPROM), NULL},
{GEN_CMD_CODE(_Read_EFUSE), NULL},
{GEN_CMD_CODE(_Write_EFUSE), NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index cb44119ce..e4e7e350d 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -636,7 +636,7 @@ enum {
GEN_CMD_CODE(_Write_BBREG),
GEN_CMD_CODE(_Read_RFREG),
GEN_CMD_CODE(_Write_RFREG), /*5*/
- GEN_CMD_CODE(_Read_EEPROM),
+ GEN_CMD_CODE(_read_eeprom),
GEN_CMD_CODE(_Write_EEPROM),
GEN_CMD_CODE(_Read_EFUSE),
GEN_CMD_CODE(_Write_EFUSE),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 208040874..63373d665 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -684,7 +684,7 @@ enum {
GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
GEN_EVT_CODE(_Read_BBREG),
GEN_EVT_CODE(_Read_RFREG),
- GEN_EVT_CODE(_Read_EEPROM),
+ GEN_EVT_CODE(_read_eeprom),
GEN_EVT_CODE(_Read_EFUSE),
GEN_EVT_CODE(_Read_CAM), /*5*/
GEN_EVT_CODE(_Get_BasicRate),
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom
2025-05-20 22:26 Donny-Dev
@ 2025-05-21 4:21 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2025-05-21 4:21 UTC (permalink / raw)
To: Donny-Dev; +Cc: linux-staging, linux-kernel
On Tue, May 20, 2025 at 10:26:10PM +0000, Donny-Dev wrote:
> This patch fixes a checkpatch
> warning by renaming the function
> _Read_EEPROM to follow the
> kernel coding style (snake_case).
>
> Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 1c9e8b01d..557bfdf09 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> {GEN_CMD_CODE(_Write_BBREG), NULL},
> {GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
> {GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
> - {GEN_CMD_CODE(_Read_EEPROM), NULL},
> + {GEN_CMD_CODE(_read_eeprom), NULL},
> {GEN_CMD_CODE(_Write_EEPROM), NULL},
> {GEN_CMD_CODE(_Read_EFUSE), NULL},
> {GEN_CMD_CODE(_Write_EFUSE), NULL},
> diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> index cb44119ce..e4e7e350d 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> @@ -636,7 +636,7 @@ enum {
> GEN_CMD_CODE(_Write_BBREG),
> GEN_CMD_CODE(_Read_RFREG),
> GEN_CMD_CODE(_Write_RFREG), /*5*/
> - GEN_CMD_CODE(_Read_EEPROM),
> + GEN_CMD_CODE(_read_eeprom),
> GEN_CMD_CODE(_Write_EEPROM),
> GEN_CMD_CODE(_Read_EFUSE),
> GEN_CMD_CODE(_Write_EFUSE),
> diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> index 208040874..63373d665 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> @@ -684,7 +684,7 @@ enum {
> GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
> GEN_EVT_CODE(_Read_BBREG),
> GEN_EVT_CODE(_Read_RFREG),
> - GEN_EVT_CODE(_Read_EEPROM),
> + GEN_EVT_CODE(_read_eeprom),
> GEN_EVT_CODE(_Read_EFUSE),
> GEN_EVT_CODE(_Read_CAM), /*5*/
> GEN_EVT_CODE(_Get_BasicRate),
> --
> 2.43.0
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-22 4:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-22 3:15 [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom Donny Turizo
2025-05-22 4:42 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-05-22 3:50 Donny Turizo
2025-05-22 4:44 ` Greg KH
2025-05-20 22:26 Donny-Dev
2025-05-21 4:21 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox