[PATCH v2] stating: media: atomisp: fix open brace placement

[PATCH v2] stating: media: atomisp: fix open brace placement

[Woohee Yang]

Fix checkpatch error "ERROR: that open brace { should be on the previous
line" in isp_param.c

Signed-off-by: Woohee Yang <woohee9527@gmail.com>

---

Hey, this is my first patch, I appreciate any feedback, thank you!

Changelog:
v2: modified commit message
v1: https://lore.kernel.org/linux-media/20250714135014.212067-1-woohee9527@gmail.com/
---
 .../media/atomisp/pci/runtime/isp_param/src/isp_param.c     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
index 251dd75a7613..b4aac76c2ed5 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
@@ -102,8 +102,7 @@ ia_css_isp_param_allocate_isp_parameters(
 	unsigned int mem, pclass;
 
 	pclass = IA_CSS_PARAM_CLASS_PARAM;
-	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) {
 		for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) {
 			u32 size = 0;
 
@@ -178,8 +177,7 @@ ia_css_isp_param_copy_isp_mem_if_to_ddr(
     enum ia_css_param_class pclass) {
 	unsigned int mem;
 
-	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) {
 		size_t       size	  = host->params[pclass][mem].size;
 		ia_css_ptr ddr_mem_ptr  = ddr->params[pclass][mem].address;
 		char	    *host_mem_ptr = host->params[pclass][mem].address;
-- 
2.47.2

Re: [PATCH v2] stating: media: atomisp: fix open brace placement

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 5:07 PM Woohee Yang <woohee9527@gmail.com> wrote:
>
> Fix checkpatch error "ERROR: that open brace { should be on the previous
> line" in isp_param.c

Missing period at the end.

...

> Hey, this is my first patch, I appreciate any feedback, thank you!

Already second iteration of it :-)

Is this the only file in that driver with the same issue? There is
another patch floating around, perhaps you can combine the efforts, so
only one patch for the same issue for the whole driver can be applied?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] stating: media: atomisp: fix open brace placement

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 5:07 PM Woohee Yang <woohee9527@gmail.com> wrote:
>
> Fix checkpatch error "ERROR: that open brace { should be on the previous
> line" in isp_param.c

In case Hans wants to apply this,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
with the added period in the commit message.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] stating: media: atomisp: fix open brace placement

[Sakari Ailus]

Hi,

On Mon, Jul 14, 2025 at 08:39:02PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 14, 2025 at 5:07 PM Woohee Yang <woohee9527@gmail.com> wrote:
> >
> > Fix checkpatch error "ERROR: that open brace { should be on the previous
> > line" in isp_param.c
> 
> In case Hans wants to apply this,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> with the added period in the commit message.

No longer applies to my atomisp branch. :-\

-- 
Sakari Ailus