From: Greg KH <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix block comment end markers
Date: Wed, 16 Jul 2025 09:36:20 +0200 [thread overview]
Message-ID: <2025071643-reunion-escalator-5f6b@gregkh> (raw)
In-Reply-To: <20250716053604.64798-1-ignacio.pena87@gmail.com>
On Wed, Jul 16, 2025 at 01:36:02AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
>
> Fix checkpatch warnings about block comment style by moving the
> closing comment marker '*/' to a separate line.
>
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 7a74b011d..1e2b3c456 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -70,7 +70,8 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)
> * When Who Remark
> * 11/17/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> + *---------------------------------------------------------------------------
This line can now just be removed, right?
Same for all of these long "------" comment lines, they aren't needed as
this isn't the kernel coding style.
thanks,
greg k-h
prev parent reply other threads:[~2025-07-16 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 5:36 [PATCH 1/3] staging: rtl8723bs: fix block comment end markers Ignacio Peña
2025-07-16 5:36 ` [PATCH 2/3] staging: rtl8723bs: add missing blank line after declaration Ignacio Peña
2025-07-16 7:37 ` Greg KH
2025-07-16 5:36 ` [PATCH 3/3] staging: rtl8723bs: fix indentation in commented code Ignacio Peña
2025-07-16 7:38 ` Greg KH
2025-07-16 7:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071643-reunion-escalator-5f6b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox